From: Lars Ingebrigtsen <larsi@gnus.org>
To: Mark Oteiza <mvoteiza@udel.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] bind n and p in eww bookmark and histories
Date: Thu, 10 Nov 2016 19:12:28 +0100 [thread overview]
Message-ID: <m360nvw6er.fsf@gnus.org> (raw)
In-Reply-To: <87zil816lq.fsf@udel.edu> (Mark Oteiza's message of "Wed, 09 Nov 2016 20:11:45 -0500")
Mark Oteiza <mvoteiza@udel.edu> writes:
> I'd like to add these bindings. Not sure if there is a plan for n and p
> to do something else in eww's bookmark or history, judging from the
> comments nixed below.
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 7672bf0..1732682 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
> (define-key map [(control k)] 'eww-bookmark-kill)
> (define-key map [(control y)] 'eww-bookmark-yank)
> (define-key map "\r" 'eww-bookmark-browse)
> + (define-key map "n" 'next-line)
> + (define-key map "p" 'previous-line)
>
> (easy-menu-define nil map
> "Menu for `eww-bookmark-mode-map'."
> @@ -1818,8 +1820,8 @@ eww-history-browse
> (defvar eww-history-mode-map
> (let ((map (make-sparse-keymap)))
> (define-key map "\r" 'eww-history-browse)
> -;; (define-key map "n" 'next-error-no-select)
> -;; (define-key map "p" 'previous-error-no-select)
> + (define-key map "n" 'next-line)
> + (define-key map "p" 'previous-line)
I'm not sure taking keystrokes we may well want to use later for cursor
movements makes all that much sense. People are perfectly capable to
move the point around without mode-specific bindings, I think. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-11-10 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 1:11 [PATCH] bind n and p in eww bookmark and histories Mark Oteiza
2016-11-10 18:12 ` Lars Ingebrigtsen [this message]
2016-11-10 18:18 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m360nvw6er.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=mvoteiza@udel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).