From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build Date: Fri, 17 May 2019 14:39:31 +0200 Message-ID: References: <831s0xd3z1.fsf@gnu.org> <83pnohbhny.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="21444"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii , Stefan Monnier , Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 14:39:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRc9U-0005Po-FX for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 14:39:56 +0200 Original-Received: from localhost ([127.0.0.1]:48020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRc9T-0002U0-1C for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 08:39:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRc9N-0002Tk-6E for emacs-devel@gnu.org; Fri, 17 May 2019 08:39:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRc9M-0007p0-2I for emacs-devel@gnu.org; Fri, 17 May 2019 08:39:49 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:34450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRc9C-0007bV-TZ; Fri, 17 May 2019 08:39:42 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hRc95-0002td-OQ; Fri, 17 May 2019 14:39:34 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAKlBMVEUCAgXT0tICDBwsYLxm fq8HIluUoMGztcX5+fjo5+cOOY3///8RR6qDkK9i90IwAAACYklEQVQ4jbWTv2vbQBTHj0DHDrdE aCgYgRfTDuZUDUaB0rsqEBooarQIOgSLc4dkEAlWf5ChS7HIpM1H6JSqw6EMWYqDR29Cg+MkdpOi /6VPsRznhyl06FdIOvS5d+/dPX0RXiwF9Rer98+gPwcY+0Eo7oKeEKEQUaRGMOiK/TkIw05XdEQ3 hAnd7hz0j2G++KKqorgObuX4Ocm/+fll6/Ly1yT4fQscT4KvUXvzg/rebymf71X1sNwn+QOdXoML x01iW9PcTIJiR6ugx9dgJBNixrZzaGagVNpapQRJYvCG4+qUgMzUsbUSvDUNf0tKizcJYySTjv2s BJQwUyabiqcHnJpASuB6sESa8DY1xDKjJANQHPuFa+mcZoMmIbrfXlWaaTwFZwNrjJtE38oyYnHG aRq/mwKdtbFnrEO1g3VmFUmOrsEoZpzrEwu+kyYzPDNLpxFDdjRpuhwAIVAGo2aZY/jjqvXJOfcy nY8p0bfpLPlwY7e+Y3+ngyDYy8fFRsrkw43JypVW26lHCg629Zxms4iafhhrVaZGHCu7RtuUzgwc vtI0Z9Uj675C9XNTlhEjJ2lAN3S6woMWNdekM4uoSoKWqv6eHwScpXC4Wgk09zlC1df1Zd7mZxKa WSnBUu0lQjVjl7A8X4PWatDaErxA6Cn0iFheA5qPZgDV3kBENoDDasTF96UZqFYgh+NK141tGKJH 050v/K/+7qgwwmr/JMTqwT1wApYBG2Asije4p1sCfOp/jMBSqo/BUqoQYm7OXnkXz/2bpUBgsk5Y OBE8178NOuJGnTtgcbn/BfTmoz+NAH4eSglu7wAAAABJRU5ErkJggg== In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 17 May 2019 14:31:21 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236661 Archived-At: That should be: diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index e76baf5ed0..9502a139d1 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -337,12 +337,19 @@ byte-compile-warnings (or (symbolp v) (null (delq nil (mapcar (lambda (x) (not (symbolp x))) v)))))) -(defun byte-compile-warning-enabled-p (warning) +(defun byte-compile-warning-enabled-p (warning &optional symbol) "Return non-nil if WARNING is enabled, according to `byte-compile-warnings'." - (or (eq byte-compile-warnings t) - (if (eq (car byte-compile-warnings) 'not) - (not (memq warning byte-compile-warnings)) - (memq warning byte-compile-warnings)))) + ;; Don't issue a warning for SYMBOL being obsolete if called from + ;; within an obsolete function. + (and (not (and symbol + (eq warning 'obsolete) + byte-compile-current-form + (get byte-compile-current-form 'byte-obsolete-info) + (not (memq symbol byte-compile-not-obsolete-funcs)))) + (or (eq byte-compile-warnings t) + (if (eq (car byte-compile-warnings) 'not) + (not (memq warning byte-compile-warnings)) + (memq warning byte-compile-warnings))))) ;;;###autoload (defun byte-compile-disable-warning (warning) @@ -1268,7 +1275,7 @@ byte-compile-warn (defun byte-compile-warn-obsolete (symbol) "Warn that SYMBOL (a variable or function) is obsolete." - (when (byte-compile-warning-enabled-p 'obsolete) + (when (byte-compile-warning-enabled-p 'obsolete symbol) (let* ((funcp (get symbol 'byte-obsolete-info)) (msg (macroexp--obsolete-warning symbol -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no