From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt Date: Sun, 16 Jun 2019 21:52:03 +0200 Message-ID: References: <20190616141010.24607.84378@vcs0.savannah.gnu.org> <20190616141013.5EE5F20B45@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25926"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 21:52:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcbCp-0006ZM-Hf for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 21:52:47 +0200 Original-Received: from localhost ([::1]:42578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcbCo-0002TO-KX for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 15:52:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47600) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcbCF-0002QL-9C for emacs-devel@gnu.org; Sun, 16 Jun 2019 15:52:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcbCE-0008Ep-8h for emacs-devel@gnu.org; Sun, 16 Jun 2019 15:52:11 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcbCE-0008Dm-2N for emacs-devel@gnu.org; Sun, 16 Jun 2019 15:52:10 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcbC7-0005hE-CI; Sun, 16 Jun 2019 21:52:07 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEXNmVK7h0ZJJhHXqm3Z y77a7+7G5+7S4N+qdzeUYiiYrFUiAAACSElEQVQ4jW2STU/cMBCGJwqqOCZSK4Uj5kJuQU5bOKIM XThWwmz7A7o9V8ri9rbZgmTfuoGq9r/tOwlb2O2OnIk9z3z5g25nu4UmdpzYLQ+q+cPMTmw72QZ7 zLOWmbfshjRPdlT4YqjZWVrAuy3TaDd0/eo5rxjMjSjTkqnXnlhOjbF2jq9lMs2tNHSD9XRupy1b a2yTr8jwe2tuv9q1zBF4mmc/yZja8mRuzShTa1nva60BeO06hdW2eZFWWtd0PWlCnhMRvHAAXC1I N8wCOINNV4PKXZpqXoOa/4lGIMx8AsCsBnmL0tzoGhm/lXGP4L8JlkcXH0v/mngjQj3UyweA/n4j YsrqCBHzT0rdATRrMG8HcGg2wRuc3DO4fwFwgIwtLw8vviv1W0A/gFpuHr0ujy+uNsDduEMA/vw/ kH0c8481iKEjumN9kju/6ku+HIH+RYSjy9IKujqJA/jzBETSavzvr86UesSRnGf0QgT7EVzmJCiV uyINoIkOHgBOn71FVcKrAveRbQJJliKIeSEr3HqCviiREEhC3HQZHkMi80HRE0TtosizIaIoCpfR 8GQAzpz3RefyvMjgElyS0RjhYnRYu84tOlgT6UFq8cq7rnACuuHhjc0ldO4REWEGWgAUkiqBy9Wy jKXqu7iMIca48rF0+HI6kwgXuxAAOu+8lM8LR06KeycjyAQUiQACImL00EMxqKEV/wQgyBVDj4k7 8PCg2JdlX8ZelWHgJYwBpQTEqPAeBGCUwaE1AJiwGrSAXoXoMfxf+gJTLp3vyekAAAAASUVORK5C YII= In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 16 Jun 2019 21:43:24 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237744 Archived-At: Lars Ingebrigtsen writes: > Stefan Monnier writes: > >>> +(require 'cl-extra) >> >> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra) >> is supposed to be an internal implementation detail. > > That's what I had originally, but then I got this warning: > > In end of data: > emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is > not known to be defined. > > Perhaps because it's an internal(ish) function? Hm... Perhaps that should have been a call to cl-describe-type instead, despite what (define-obsolete-function-alias 'eieio-help-class 'cl--describe-class "25.1") says... I'll do some testing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no