From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: pcomplete Date: Mon, 17 Jun 2019 14:08:49 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120361"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 17 14:23:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcqfM-000VBL-Qj for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 14:23:16 +0200 Original-Received: from localhost ([::1]:46694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcqfL-0005Md-NV for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 08:23:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35543) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcqRZ-0005RP-CH for emacs-devel@gnu.org; Mon, 17 Jun 2019 08:09:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcqRX-0003R7-Ba for emacs-devel@gnu.org; Mon, 17 Jun 2019 08:09:01 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:39718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcqRX-0003MQ-4n for emacs-devel@gnu.org; Mon, 17 Jun 2019 08:08:59 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcqRN-0004Oe-FN; Mon, 17 Jun 2019 14:08:51 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEXAu61AWH7g0abj1awp Q2kSEhfl2bFkb4WPkpjx68/QWlioAAACY0lEQVQ4jVWUTWvjMBCGp1lwlFsFXpzj4ly6t2KD7wGF /oGEXg0GUd8aNiDvTS5LNb3lFPC/3VeSlaRDcBI9ejWaL1Ndl8mY069NuSFdV/M/Z+N37a0i3c0S XpQ30NTUzAp3PbHc1LXuyBhmpvLeAJqOFOwA26vBsF2k0zrayoGP6s+zcOMubHgxYQMVhmmpPjpd scmDNhqZwTZv6sem+sXuO2Dbv/mrnglH3ggNTFNLi8XvqRVGqt0N2GzSuiQG8JJEiG12yfrnB/XV krg7DKAnolGpNb6Ek/msoXfq34RElNvCQmKMjHejApcacx+/evGEcesA1JCJJUCu8q3NiCwlIIsj IlNSrp3VGo4SUFspA/iaYLpvrwAGIosp2gV3TgCaWQAJEpDvZuDXZR/3Cx5Dlj2QgwWIgtaZcfsz Oe8nx+soICYX0oIKyjUcLh/jOgCH0Ek6uV7hBPi+eIFjlsE5LwvzdzqT35+FZPmPQgWtmFZzBFh3 oZ34dKDRTskuPv8FWyZhDOpxBefP6XL0ZQE4IptpvRWry1IO7wBwg76aJe1g+/NoDAA8ScRRZDoA LInVWeLpUHof4LuOdSDKpvbhUThfdxRKFugtwUTgLdGnOKmYXemRsbRCmMgI0Wm/OyiaqyHXvvFa Mfjotnkuab+PBSlspoVPlRl3r0fEkXrVz4UsiuFJHHc4RFHlE3dKjfn6L/Uo6Ubrzs9nzOBtDLQ3 TK4QH3H+/AnokwhKtOY8mH7K8WYoZ3BbbTQemzqATodtGPDGO2xq/06ICl1WZQUYHd6DLj6beJP6 6uOb1VW1qcr/8jdZH6A2jWcAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Wed, 12 Jun 2019 18:07:04 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237778 Archived-At: Stefan Monnier writes: >> This one I'm not sure what the status is with: It's an obsolete >> variable, but it seems unsure how it should be replaced here, > > Right, it should be replaced by obsoleting the `pcomplete` command (not > the package). > >> In pcomplete/tar: >> pcmpl-gnu.el:162:47:Warning: `pcomplete-suffix-list' is an obsolete variable >> (as of 24.1). >> >> I'm not sure whether suppressing this warning is the right thing, >> either... > > Agreed. Actually, looking at the code further, I don't quite understand this one at all... These functions are the ones that are called when you hit TAB in M-x shell buffers (and the like)? So "tar --v" will complete over the completions like "--verbose"? And I guess pcomplete is one of these functions that can be used here, but it's not used by default; right. But the only place where pcomplete-suffix-alist is actually used for anything is in pcomplete-insert-entry, and this is the call trace for that: Debugger entered: nil pcomplete-insert-entry(#("--rsh-comma" 0 11 (fontified t face (and result (not (eq (car result) 'listed)) (cdr result) (pco (let* ((pcomplete-stub) pcomplete-seen pcomplete-norm-func pc (catch 'pcompleted (let* ((pcomplete-stub) pcomplete-seen pco (if (and interactively pcomplete-cycle-completions pcomplete- pcomplete(1) funcall-interactively(pcomplete 1) call-interactively(pcomplete record nil) command-execute(pcomplete record) execute-extended-command(nil "pcomplete" nil) funcall-interactively(execute-extended-command nil "pcomplete" nil) call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) And, as we can see, that function is not called from pcomplete/tar, so the binding of pcomplete-insert-entry in pcomplete/tar doesn't seem like it could possibly affect anything? Am I misreading the code? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no