From: prj@po.cwru.edu (Paul Jarc)
Cc: emacs-devel@gnu.org
Subject: Re: don't process $(LDFLAGS) with prefix-args
Date: Fri, 28 Mar 2003 13:08:43 -0500 [thread overview]
Message-ID: <m34r5nqs72.fsf@multivac.cwru.edu> (raw)
In-Reply-To: <m3ptocczok.fsf@multivac.cwru.edu> (prj@po.cwru.edu's message of "Thu, 27 Mar 2003 15:38:29 -0500")
I wrote:
> The distributed Makefile.in's are similar enough, but somewhere in the
> 21.2 build process, Makefile.in is modified like so:
Sorry, my mistake. That isn't happening; I had simply patched my 21.2
this way to make it compile. So the bug hasn't reappeared - it was
never fixed. :/ ISTR what happened was that I posted this patch for
21.1 or 21.2, and it was agreed that it should be applied, but
apparently it never was. It still works for me with 21.3.
The patch makes it so the user-supplied LDFLAGS is not processed by
YMF_PASS_LDFLAGS. So on systems where $(LD) is $(CC), this patch
changes the interpretation of LDFLAGS in src/ to match its
interpretation in other subdirectories. On systems where $(LD) is ld,
YMF_PASS_LDFLAGS is a no-op, so there is no real change: the
interpretation is still inconsistent among subdirectories.
--- Makefile.in.2 2003-03-27 14:42:33.000000000 -0500
+++ emacs-21.2/src/Makefile.in 2003-03-27 14:57:21.000000000 -0500
@@ -495,7 +495,7 @@
#endif /* not ORDINARY_LINK */
ALL_LDFLAGS = LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_TEMACS LD_SWITCH_MACHINE \
- LD_SWITCH_MACHINE_TEMACS LD_SWITCH_SITE $(LDFLAGS)
+ LD_SWITCH_MACHINE_TEMACS LD_SWITCH_SITE
/* A macro which other sections of Makefile can redefine to munge the
flags before they're passed to LD. This is helpful if you have
@@ -868,7 +868,7 @@
#endif
temacs: MAKE_PARALLEL $(LOCALCPP) $(STARTFILES) stamp-oldxmenu ${obj} ${otherobj} OBJECTS_MACHINE prefix-args
- $(LD) YMF_PASS_LDFLAGS (${STARTFLAGS} ${ALL_LDFLAGS}) \
+ $(LD) YMF_PASS_LDFLAGS (${STARTFLAGS} ${ALL_LDFLAGS}) $(LDFLAGS) \
-o temacs ${STARTFILES} ${obj} ${otherobj} \
OBJECTS_MACHINE ${LIBES}
paul
prev parent reply other threads:[~2003-03-28 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 22:31 don't process $(LDFLAGS) with prefix-args Paul Jarc
2003-03-27 19:04 ` Richard Stallman
2003-03-27 20:38 ` Paul Jarc
2003-03-28 15:21 ` Richard Stallman
2003-03-28 18:08 ` Paul Jarc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34r5nqs72.fsf@multivac.cwru.edu \
--to=prj@po.cwru.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).