* broken input mechanism
@ 2004-02-24 19:07 Tak Ota
2004-02-24 21:10 ` Kim F. Storm
0 siblings, 1 reply; 3+ messages in thread
From: Tak Ota @ 2004-02-24 19:07 UTC (permalink / raw
The current keyboard.c is broken on W32 platform. When key input
accumulates substantially (auto repeating key faster than redisplay)
Emacs crashes variety of way. On the latest revision 1.766 it always
crashes in get_filtered_input_pending where addr holding bogus value
(mostly 0x04000000, rarely 0x00000000). Strangely the call stack
only shows get_filtered_input_pending and get_input_pending but
nothing before under VC++ debugger.
Revision must go back to 1.761 to have a good build without this
problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: broken input mechanism
2004-02-24 19:07 broken input mechanism Tak Ota
@ 2004-02-24 21:10 ` Kim F. Storm
2004-02-25 2:41 ` Tak Ota
0 siblings, 1 reply; 3+ messages in thread
From: Kim F. Storm @ 2004-02-24 21:10 UTC (permalink / raw
Cc: emacs-devel
Tak Ota <Takaaki.Ota@am.sony.com> writes:
> The current keyboard.c is broken on W32 platform. When key input
> accumulates substantially (auto repeating key faster than redisplay)
> Emacs crashes variety of way. On the latest revision 1.766 it always
> crashes in get_filtered_input_pending where addr holding bogus value
> (mostly 0x04000000, rarely 0x00000000). Strangely the call stack
> only shows get_filtered_input_pending and get_input_pending but
> nothing before under VC++ debugger.
>
> Revision must go back to 1.761 to have a good build without this
> problem.
Does the following patch fix this?
Index: w32term.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
retrieving revision 1.206
diff -c -r1.206 w32term.c
*** w32term.c 22 Feb 2004 22:41:52 -0000 1.206
--- w32term.c 24 Feb 2004 20:09:24 -0000
***************
*** 4168,4174 ****
/* TODO: tool-bars, ghostscript integration, mouse
cursors. */
! while (get_next_msg (&msg, FALSE))
{
switch (msg.msg.message)
{
--- 4168,4174 ----
/* TODO: tool-bars, ghostscript integration, mouse
cursors. */
! while (numchars > 0 && get_next_msg (&msg, FALSE))
{
switch (msg.msg.message)
{
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: broken input mechanism
2004-02-24 21:10 ` Kim F. Storm
@ 2004-02-25 2:41 ` Tak Ota
0 siblings, 0 replies; 3+ messages in thread
From: Tak Ota @ 2004-02-25 2:41 UTC (permalink / raw
Cc: emacs-devel
Yes, it indeed has fixed the problem. Thanks Kim.
-Tak
24 Feb 2004 22:10:50 +0100: storm@cua.dk (Kim F. Storm) wrote:
> Tak Ota <Takaaki.Ota@am.sony.com> writes:
>
> > The current keyboard.c is broken on W32 platform. When key input
> > accumulates substantially (auto repeating key faster than redisplay)
> > Emacs crashes variety of way. On the latest revision 1.766 it always
> > crashes in get_filtered_input_pending where addr holding bogus value
> > (mostly 0x04000000, rarely 0x00000000). Strangely the call stack
> > only shows get_filtered_input_pending and get_input_pending but
> > nothing before under VC++ debugger.
> >
> > Revision must go back to 1.761 to have a good build without this
> > problem.
>
> Does the following patch fix this?
>
> Index: w32term.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
> retrieving revision 1.206
> diff -c -r1.206 w32term.c
> *** w32term.c 22 Feb 2004 22:41:52 -0000 1.206
> --- w32term.c 24 Feb 2004 20:09:24 -0000
> ***************
> *** 4168,4174 ****
>
> /* TODO: tool-bars, ghostscript integration, mouse
> cursors. */
> ! while (get_next_msg (&msg, FALSE))
> {
> switch (msg.msg.message)
> {
> --- 4168,4174 ----
>
> /* TODO: tool-bars, ghostscript integration, mouse
> cursors. */
> ! while (numchars > 0 && get_next_msg (&msg, FALSE))
> {
> switch (msg.msg.message)
> {
>
> --
> Kim F. Storm <storm@cua.dk> http://www.cua.dk
>
>
>
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-25 2:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-24 19:07 broken input mechanism Tak Ota
2004-02-24 21:10 ` Kim F. Storm
2004-02-25 2:41 ` Tak Ota
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).