From: storm@cua.dk (Kim F. Storm)
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Another bug with the macro counter
Date: Sun, 31 Oct 2004 00:43:56 +0200 [thread overview]
Message-ID: <m34qkbn7wz.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <200410302204.i9UM4vl03402@raven.dms.auburn.edu> (Luc Teirlinck's message of "Sat, 30 Oct 2004 17:04:57 -0500 (CDT)")
I think your patch is imcomplete (so is mine) --
we only want the kmacro cleanup to happen if we are
currently defining a macro, your patch does it always
Here is the correct function:
(or (not defining-kbd-macro)
appending-to-kbd-macro
;; Just for safety. kmacro.el should be loaded if we got here.
;; Nothing else sets `appending-to-kbd-macro' to t.
(not (featurep 'kmacro))
(with-no-warnings (kmacro-ring-empty-p))
(with-no-warnings (kmacro-pop-ring)))
(setq appending-to-kbd-macro nil)
(setq defining-kbd-macro nil)
In any case, I still think my approach is cleaner and better.
Luc Teirlinck <teirllm@dms.auburn.edu> writes:
> ***************
> *** 3916,3921 ****
> --- 3922,3933 ----
> At top-level, as an editor command, this simply beeps."
> (interactive)
> (deactivate-mark)
> + (or appending-to-kbd-macro
> + ;; Just for safety. kmacro.el should be loaded if we got here.
> + ;; Nothing else sets `appending-to-kbd-macro' to t.
> + (not (featurep 'kmacro))
> + (with-no-warnings (kmacro-ring-empty-p))
> + (with-no-warnings (kmacro-pop-ring)))
> (setq defining-kbd-macro nil)
> (signal 'quit nil))
>
> ============================================================
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2004-10-30 22:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 1:07 Another bug with the macro counter Luc Teirlinck
2004-10-30 2:38 ` Luc Teirlinck
2004-10-30 3:27 ` Luc Teirlinck
2004-10-30 4:06 ` Stefan
2004-10-30 14:19 ` Luc Teirlinck
2004-10-30 16:12 ` Stefan
2004-10-30 18:06 ` David Kastrup
2004-10-30 23:13 ` Luc Teirlinck
2004-10-31 0:09 ` Stefan
2004-10-31 7:43 ` David Kastrup
2004-10-31 13:30 ` Andreas Schwab
2004-10-31 17:05 ` Stefan
2004-10-31 18:36 ` David Kastrup
2004-10-31 18:52 ` Luc Teirlinck
2004-10-30 14:24 ` Luc Teirlinck
2004-10-30 14:51 ` Luc Teirlinck
2004-10-30 21:57 ` Kim F. Storm
2004-10-30 22:04 ` Luc Teirlinck
2004-10-30 22:09 ` Luc Teirlinck
2004-10-30 22:43 ` Kim F. Storm [this message]
2004-10-31 21:01 ` Luc Teirlinck
2004-10-31 23:23 ` Kim F. Storm
2004-11-01 7:24 ` Richard Stallman
2004-10-31 9:42 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34qkbn7wz.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).