From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Several suggestions for image support Date: 25 Apr 2004 03:56:39 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200404230033.JAA10583@etlken.m17n.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1082851155 19028 80.91.224.253 (24 Apr 2004 23:59:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 24 Apr 2004 23:59:15 +0000 (UTC) Cc: dak@gnu.org, rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Apr 25 01:59:05 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BHX33-0007gC-00 for ; Sun, 25 Apr 2004 01:59:05 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BHX2z-00053I-00 for ; Sun, 25 Apr 2004 01:59:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHX2s-0000F6-F1 for emacs-devel@quimby.gnus.org; Sat, 24 Apr 2004 19:58:54 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BHX2e-00009t-H3 for emacs-devel@gnu.org; Sat, 24 Apr 2004 19:58:40 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BHX26-0008EK-Ui for emacs-devel@gnu.org; Sat, 24 Apr 2004 19:58:38 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHX1B-0007XI-Ju; Sat, 24 Apr 2004 19:57:09 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id 1727747FE1E; Sun, 25 Apr 2004 01:56:55 +0200 (CEST) Original-To: Kenichi Handa In-Reply-To: <200404230033.JAA10583@etlken.m17n.org> Original-Lines: 44 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22108 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22108 I have now reworked my line height changes. Now, the height of a newline equals the current face height, unless an explicit line-spacing property is present on the newline character. If the value of the line-spacing property is t, you get the effect of my previous change, i.e. the newline character does not add to the height of the row by itself, but the newline glyph is re-positioned inside the available row height to make it fully visible (when the cursor is above it). If the value is an integer, it overrides the value of the frame line-spacing parameter and the (buffer local) value of the line-spacing variable. If the value is a float, the number of extra pixels is calculated as the current row height * value. I think this covers all the objections raised. Try this: (make-face 'small) (set-face-attribute 'small nil :height 0.5) (insert (propertize "abc\ndef\nghi" 'face 'small) (propertize "\n" 'line-spacing t) (propertize "jkl" 'face 'small) "\n") Kenichi Handa writes: > By the way, it seems that the current code doesn't draw a > hollow cursor correctly. The bottom line of the rectangle > is not drawn (see the attached image). That's an old bug which probably never got noticed because lines were never less that the default face height. I fixed that too. -- Kim F. Storm http://www.cua.dk