From: storm@cua.dk (Kim F. Storm)
Cc: Magnus Henoch <mange@freemail.hu>, emacs-devel@gnu.org
Subject: Re: [mange@freemail.hu: grep-tree doesn't shell-quote-argument]
Date: Tue, 18 Apr 2006 16:02:44 +0200 [thread overview]
Message-ID: <m33bgbnfqz.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <E1FVplu-0005th-51@fencepost.gnu.org> (Richard Stallman's message of "Tue, 18 Apr 2006 08:57:34 -0400")
Richard Stallman <rms@gnu.org> writes:
> Since M-x grep does not do this, I am not sure it is desirable
> to make M-x grep-tree incompatible with it. But I don't use
> grep-tree. What do others think?
M-x grep prompts for the entire command line, so the user can easily
add the necessary quoting of the regexp.
M-x grep-tree prompts individually for the regexp, files, and directory,
so I think it makes good sense to quote the regexp automatically.
It would make sense to rewrite the following line to use
shell-quote-argument as well:
> (and files (concat "-name '" files "'"))
i.e.
(and files (concat "-name " (shell-quote-argument files)))
>
> From: Magnus Henoch <mange@freemail.hu>
> Subject: grep-tree doesn't shell-quote-argument
> To: emacs-pretest-bug@gnu.org
> Date: Mon, 17 Apr 2006 23:17:14 +0200
> Mail-Followup-To: emacs-pretest-bug@gnu.org
> Mail-Copies-To: never
>
> - --=-=-=
>
> grep-tree doesn't quote its regexp argument to protect it from the
> shell. This makes it harder to use * and ? in regexps. I propose
> this patch:
>
> 2006-04-17 Magnus Henoch <mange@freemail.hu>
>
> * progmodes/grep.el (grep-tree): Call shell-quote-argument on
> regexp.
>
>
> - --=-=-=
> Content-Type: text/x-patch
> Content-Disposition: inline
>
> *** orig/lisp/progmodes/grep.el
> - --- mod/lisp/progmodes/grep.el
> ***************
> *** 631,637 ****
> (setq files (cdr mf)))))
> (let ((command-args (grep-expand-command-macros
> grep-tree-command
> ! (setq grep-tree-last-regexp regexp)
> (and files (concat "-name '" files "'"))
> (if subdirs
> (if (stringp subdirs)
> - --- 632,638 ----
> (setq files (cdr mf)))))
> (let ((command-args (grep-expand-command-macros
> grep-tree-command
> ! (shell-quote-argument (setq grep-tree-last-regexp regexp))
> (and files (concat "-name '" files "'"))
> (if subdirs
> (if (stringp subdirs)
>
> - --=-=-=
> Content-Type: text/plain; charset="us-ascii"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
>
> _______________________________________________
> emacs-pretest-bug mailing list
> emacs-pretest-bug@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
>
> - --=-=-=--
> ----------
>
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2006-04-18 14:02 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 12:57 [mange@freemail.hu: grep-tree doesn't shell-quote-argument] Richard Stallman
2006-04-18 14:02 ` Kim F. Storm [this message]
2006-04-18 14:44 ` Eli Zaretskii
2006-04-18 15:11 ` Eric Hanchrow
2006-04-18 15:18 ` Lennart Borgman
2006-04-19 8:59 ` Kim F. Storm
2006-04-19 9:15 ` Romain Francoise
2006-04-19 9:16 ` Eli Zaretskii
2006-04-19 11:41 ` Kim F. Storm
2006-04-19 12:23 ` David Kastrup
2006-04-19 12:51 ` Kim F. Storm
2006-04-19 13:09 ` David Kastrup
2006-04-19 21:13 ` Richard Stallman
2006-04-19 13:14 ` Stefan Monnier
2006-04-19 13:28 ` David Kastrup
2006-04-19 13:58 ` Stefan Monnier
2006-04-19 14:09 ` David Kastrup
2006-04-19 14:58 ` Kim F. Storm
2006-04-19 15:10 ` David Kastrup
2006-04-19 16:59 ` Kevin Rodgers
2006-04-19 17:08 ` David Kastrup
2006-04-19 14:52 ` Kim F. Storm
2006-04-19 15:03 ` David Kastrup
2006-04-19 18:10 ` Bill Wohler
2006-04-19 18:15 ` Drew Adams
2006-04-19 18:23 ` David Kastrup
2006-04-19 18:34 ` Bill Wohler
2006-04-19 21:13 ` Richard Stallman
2006-04-19 12:49 ` Stefan Monnier
2006-04-18 15:27 ` Romain Francoise
2006-04-19 4:17 ` Richard Stallman
2006-04-19 8:57 ` Eli Zaretskii
2006-04-19 21:12 ` Richard Stallman
2006-04-20 9:53 ` Eli Zaretskii
2006-04-21 8:27 ` Kim F. Storm
2006-04-21 14:47 ` Magnus Henoch
2006-04-21 17:22 ` Stefan Monnier
2006-04-21 20:04 ` Kim F. Storm
2006-04-21 20:40 ` Stefan Monnier
2006-04-21 21:35 ` Kim F. Storm
2006-04-22 12:03 ` Richard Stallman
2006-04-22 12:41 ` David Kastrup
2006-04-23 16:06 ` Bill Wohler
2006-04-23 16:19 ` Bill Wohler
2006-04-22 23:02 ` Kim F. Storm
2006-04-23 21:58 ` Richard Stallman
2006-04-23 22:06 ` David Kastrup
2006-04-24 11:51 ` Richard Stallman
2006-04-24 12:04 ` David Kastrup
2006-04-25 16:46 ` Richard Stallman
2006-04-24 12:10 ` Kim F. Storm
2006-04-24 22:46 ` Kim F. Storm
2006-04-25 16:47 ` Richard Stallman
2006-04-24 11:05 ` Kim F. Storm
2006-04-24 11:11 ` Miles Bader
2006-04-24 11:24 ` David Kastrup
2006-04-24 11:31 ` Miles Bader
2006-04-24 11:43 ` David Kastrup
2006-04-24 11:52 ` Miles Bader
2006-04-24 17:52 ` Richard Stallman
2006-04-24 18:16 ` David Kastrup
2006-04-24 20:38 ` Chong Yidong
2006-04-25 16:48 ` Richard Stallman
2006-04-26 8:27 ` Kim F. Storm
2006-04-27 4:36 ` Richard Stallman
2006-04-25 9:06 ` Kim F. Storm
2006-04-29 3:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33bgbnfqz.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
--cc=mange@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).