From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Code cleanup. Date: Mon, 23 Oct 2006 18:50:21 +0200 Message-ID: References: <85y7r7l00o.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1161622321 30432 80.91.229.2 (23 Oct 2006 16:52:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Oct 2006 16:52:01 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 23 18:51:56 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gc31V-0004gq-JO for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 18:51:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gc31V-000604-4l for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2006 12:51:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gc315-0005vN-02 for emacs-devel@gnu.org; Mon, 23 Oct 2006 12:51:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gc311-0005tl-PR for emacs-devel@gnu.org; Mon, 23 Oct 2006 12:51:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gc311-0005te-BA for emacs-devel@gnu.org; Mon, 23 Oct 2006 12:51:07 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gc30x-0000B9-0r; Mon, 23 Oct 2006 12:51:03 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepc.post.tele.dk (Postfix) with SMTP id 30A538A0022; Mon, 23 Oct 2006 18:51:01 +0200 (CEST) Original-To: David Kastrup In-Reply-To: <85y7r7l00o.fsf@lola.goethe.zz> (David Kastrup's message of "Mon\, 23 Oct 2006 13\:55\:19 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61050 Archived-At: David Kastrup writes: > At what stage of development (if at all) should such janitorial > changes be usually applied? Code cleanup is usually welcome -- but this is not the time. > On a completely different tangent: wouldn't it be much more readable > (though likely not completely correct in some perverse manner) if > diff-mode actually had its TAB positions in column 9,17,25... instead > of the customary 8,16,24...? At least in context and unified diffs, > that would _much_ better reflect the relative indentation of the > actual change than the current behavior. > > It does not look like `tab-width' can be made to do that, but maybe > one could use a display property in order to move the information of > column 0 into the fringe. Simpler would be to put the "diff decoration" in the left margin and put the fringe outside the margins. Then the user wouldn't see any difference (except that tabs line up correctly). > But it would probably be saner if tab-width were extended to allow, > say, a cons-cell of initial offset and tab-width. Or a list (1 9 17 t) (where t means to repeat tabs every "difference between last two elements). -- Kim F. Storm http://www.cua.dk