From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Hideously slow VC status queries fixed Date: Fri, 28 Dec 2007 12:36:38 -0700 Message-ID: References: <20071227001113.3EDFE830B6E@snark.thyrsus.com> <20071228090253.GA23009@thyrsus.com> Reply-To: Tom Tromey NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198872383 9424 80.91.229.12 (28 Dec 2007 20:06:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Dec 2007 20:06:23 +0000 (UTC) Cc: esr@snark.thyrsus.com, Richard Stallman , emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 28 21:06:37 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J8LTG-0003m0-QU for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2007 21:06:19 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8LSv-0004ug-Lm for ged-emacs-devel@m.gmane.org; Fri, 28 Dec 2007 15:05:57 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J8LSs-0004ua-1u for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:05:54 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J8LSq-0004uO-B8 for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:05:53 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8LSq-0004uL-4a for emacs-devel@gnu.org; Fri, 28 Dec 2007 15:05:52 -0500 Original-Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J8LSm-0002Ni-3X; Fri, 28 Dec 2007 15:05:48 -0500 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id lBSK5lj9023879; Fri, 28 Dec 2007 15:05:47 -0500 Original-Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lBSK5lGC021817; Fri, 28 Dec 2007 15:05:47 -0500 Original-Received: from opsy.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lBSK5hcl029752; Fri, 28 Dec 2007 15:05:44 -0500 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id 6B6DA508021; Fri, 28 Dec 2007 12:36:39 -0700 (MST) X-Attribution: Tom In-Reply-To: (Tom Tromey's message of "Fri\, 28 Dec 2007 11\:46\:50 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85557 Archived-At: >>>>> "Tom" == Tom Tromey writes: Tom> I'm not really sure where to disable undo for this... maybe Tom> somewhere in dired. This patch seems to fix the undo problem. I don't get a message any more. It doesn't appear to speed up vc-dired, though. Tom ChangeLog: 2007-12-28 Tom Tromey * vc.el (vc-dired-hook): Disable undo. Index: vc.el =================================================================== RCS file: /sources/emacs/emacs/lisp/vc.el,v retrieving revision 1.501 diff -u -r1.501 vc.el --- vc.el 28 Dec 2007 18:16:55 -0000 1.501 +++ vc.el 28 Dec 2007 20:04:59 -0000 @@ -2349,7 +2349,10 @@ (if (and (vc-call-backend backend 'responsible-p default-directory) (vc-find-backend-function backend 'dir-state)) (vc-call-backend backend 'dir-state default-directory))) - (let (filename (inhibit-read-only t)) + (let (filename + (inhibit-read-only t) + ;; Temporarily disable undo. + (buffer-undo-list t)) (goto-char (point-min)) (while (not (eobp)) (cond