From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: Note on 109327 Date: Tue, 31 Jul 2012 19:35:35 +0200 Message-ID: References: <5017D1D4.2050601@yandex.ru> <83wr1jeua9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1343756172 32264 80.91.229.3 (31 Jul 2012 17:36:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Jul 2012 17:36:12 +0000 (UTC) Cc: Juanma Barranquero , dmantipov@yandex.ru, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 31 19:36:12 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SwGMb-0003r6-6d for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 19:36:09 +0200 Original-Received: from localhost ([::1]:38223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGMa-0002so-H2 for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 13:36:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGMY-0002nV-4y for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwGMT-0002or-2A for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:36:06 -0400 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:56012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwGMO-0002h9-1R; Tue, 31 Jul 2012 13:35:56 -0400 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id A9365D4D67; Tue, 31 Jul 2012 19:35:50 +0200 (CEST) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF3) Original-Received: from mf3.bahnhof.se ([127.0.0.1]) by localhost (mf3.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kyriW70NayUB; Tue, 31 Jul 2012 19:35:46 +0200 (CEST) Original-Received: from exodia.verona.se (h-235-102.a149.priv.bahnhof.se [85.24.235.102]) by mf3.bahnhof.se (Postfix) with ESMTP id 8C0F5605051; Tue, 31 Jul 2012 19:35:45 +0200 (CEST) Original-Received: from chopper.vpn.verona.se (unknown [192.168.201.10]) by exodia.verona.se (Postfix) with ESMTP id 5FCFE4E0252; Tue, 31 Jul 2012 19:35:35 +0200 (CEST) In-Reply-To: <83wr1jeua9.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Jul 2012 20:04:46 +0300") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: FreeBSD 6.x (1) X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152015 Archived-At: Eli Zaretskii writes: >> From: Juanma Barranquero >> Date: Tue, 31 Jul 2012 15:54:38 +0200 >> Cc: Emacs development discussions >> >> On Tue, Jul 31, 2012 at 2:38 PM, Dmitry Antipov wrote: >> >> > Please report possible Windows/NS build errors as soon as possible. >> >> fontset.c: In function 'dump_fontset': >> fontset.c:2119:6: error: 'struct frame' has no member named 'name' > > Which has nothing to do with Windows, but with --enable-checking. > > This problem, however, is more serious, IMO: > > gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -fno-crossjumping -Id:/usr/include/libxml2 -DGLYPH_DEBUG=1 -Demacs=1 -I../lib -I../nt/inc -DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -o oo/i386/w32menu.o w32menu.c > w32menu.c: In function `w32_menu_show': > w32menu.c:857: error: structure has no member named `title_' > makefile:322: recipe for target `oo/i386/w32menu.o' failed > make[1]: *** [oo/i386/w32menu.o] Error 1 > > AFAIU, it means that coccinelle made an incorrect replacement. > > I fixed both of these in revision 109332. > > Btw, can't we have in Emacs a feature that would allow such > refactoring? The replacements don't seem too complex to me. Adding > this to Emacs will both allow getting rid of an external tool, and be > a valuable addition to Emacs abilities. WDYT? > http://cedet.sourceforge.net/srecode.shtml The idea is that the two CEDET tools, Semantic and SRecode can cooperate to provide such features, I think. -- Joakim Verona