From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: master 9f464cc: Stop using calc for ntlm time computation Date: Tue, 27 Oct 2020 11:34:41 -0400 Message-ID: References: <20200816091703.7193.11125@vcs0.savannah.gnu.org> <20200816091705.318C0209AC@vcs0.savannah.gnu.org> <4DC436E0-825F-4785-9F28-41C761186CB4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36448"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 27 16:38:12 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXR35-0009O2-MF for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Oct 2020 16:38:11 +0100 Original-Received: from localhost ([::1]:45490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXR34-0005mR-Mv for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Oct 2020 11:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXQzn-0002B1-7A for emacs-devel@gnu.org; Tue, 27 Oct 2020 11:34:47 -0400 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:39174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXQzk-0002Ai-O8 for emacs-devel@gnu.org; Tue, 27 Oct 2020 11:34:46 -0400 Original-Received: by mail-qt1-x82f.google.com with SMTP id i7so1276757qti.6 for ; Tue, 27 Oct 2020 08:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=l+HuEZfstY11uHwnC3T+fbW8yu/6e+kjML6D3S3m0+o=; b=fUUJyuzkxtEEIvQ2SKhl0axhj8CrBmW5JDJRB3ccHOIvs+IKy3ntcoTpttKOeRq5fP ugwLAEQwZthY1a6CsOnWDkPAgkJnWFAaO6e1ltzN0WITAN7AXvgqoFXvDl2yjrrFnE/V y0R4/slsFGV1yFisEMBFHVMvaiTP9ebzLNMYVNM5lfnueDYLuuVw4m1uuKT6YhZRQUUS oVZkaYDtuPtWBhkgN1HHdAUklz0qRI7FVo9/Yoi/nvzsw+/PRQj0hAAIUlVtKVMso4Ei B1RQeGa9phET0Z6bcxndNgefYeUaPPnkfRuU9VWhCt1nQVJgnsar22gQDtJ/xPwRcGZ9 npYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=l+HuEZfstY11uHwnC3T+fbW8yu/6e+kjML6D3S3m0+o=; b=hlAAIGz+1FUI9vo6U+sH17MkBNMRyI9dU/Ya8+zgFBxhsbhHg4xMzyVwPRac3LeR3Y tHP91ipK06rgutsZFjZ6qf/4VHXk+L2AHhL0jwpFGXvbVQcuhc2kD1hSsOFyN20ybHgB 3o92qPaBdjN7tqoKemalS61237nFRNs+o6t6X3Lbpws0NH9gIVP0XGnbErIE2Tk/+DhQ ygTWbjzdggIizi5wZ2EJ1NQQzkHjOg9/GPv5uMfZTakfzw+aUKfwALimq1Iz0/TFwWla jQJAf9Q4+iczekhv69HAh2A6tky2kOa1lYfglam3clkNyDWalIvAcXSOcVl8jBFuEnr4 MZKg== X-Gm-Message-State: AOAM5309SGEgzKo9U8GKxHZ21dVMahRXB/ImNZALOqz7ctPomnpTFmTa d61kXttX2LSOvFRL7qV5GVY2tlvsC8HcvkYO X-Google-Smtp-Source: ABdhPJwXy+6IFOQwv4W28QCzCU/Mdrk71+W8q7rckeQIxZECiCu1/xvENjRIU7D+JYkWY5cs6snrPw== X-Received: by 2002:a05:622a:1c5:: with SMTP id t5mr2769306qtw.144.1603812883245; Tue, 27 Oct 2020 08:34:43 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id 6sm891080qkj.75.2020.10.27.08.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 08:34:42 -0700 (PDT) In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 27 Oct 2020 14:53:28 +0100") Received-SPF: none client-ip=2607:f8b0:4864:20::82f; envelope-from=fitzsim@fitzsim.org; helo=mail-qt1-x82f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258506 Archived-At: Mattias Engdeg=C3=A5rd writes: > 27 okt. 2020 kl. 14.06 skrev Stefan Monnier : > >>> I've pushed a new implementation. Perhaps someone with a 32-bit Emacs <= 27.1 >>> would try it out. Running the test would suffice. >>=20 >> lisp/net/ntlm-tests.el:53:1:Warning: the function =E2=80=98ntlm--time= -to-timestamp=E2=80=99 is >> not known to be defined. > > Sorry, I should have been more specific. You need to run an old (32-bit) = Emacs but with ntlm from trunk, as if using the ELPA package. > Not quite sure how that is accomplished in practice but you figure it out. On older Emacs versions you'll need the attached too, which I haven't pushed yet. Thomas diff --git a/lisp/net/ntlm.el b/lisp/net/ntlm.el index 9401430799..1de9291017 100644 --- a/lisp/net/ntlm.el +++ b/lisp/net/ntlm.el @@ -152,7 +152,9 @@ ntlm--time-to-timestamp =20 (defun ntlm-compute-timestamp () "Current time as an NTLMv2 timestamp, as a unibyte string." - (ntlm--time-to-timestamp (time-convert nil 'list))) + (ntlm--time-to-timestamp (if (functionp 'time-convert) + (time-convert nil 'list) + (append (current-time) '(0 0))))) =20 (defun ntlm-generate-nonce () "Generate a random nonce, not to be used more than once.