Patch: minor blackbox.el fix

Patch: minor blackbox.el fix

[Tom Tromey]

This patch adds a "q" key binding to blackbox, to bury the buffer.

Also, locally I found that RET was doing the wrong thing in blackbox,
and this patch arranges to redefine newline-and-indent as well.  This
fixed the problem I saw.

Tom

2008-01-06  Tom Tromey  <tromey@redhat.com>

	* play/blackbox.el (blackbox-mode-map): Rebind
	newline-and-indent.  Bind "q" to bury-buffer.

Index: lisp/play/blackbox.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/play/blackbox.el,v
retrieving revision 1.27
diff -u -r1.27 blackbox.el
--- lisp/play/blackbox.el	1 Dec 2007 09:06:35 -0000	1.27
+++ lisp/play/blackbox.el	6 Jan 2008 16:55:12 -0000
@@ -107,7 +107,9 @@
     (blackbox-redefine-key map 'move-beginning-of-line 'bb-bol)
     (define-key map " " 'bb-romp)
     (define-key map [insert] 'bb-romp)
+    (define-key map "q" 'bury-buffer)
     (blackbox-redefine-key map 'newline 'bb-done)
+    (blackbox-redefine-key map 'newline-and-indent 'bb-done)
     map))
 
 ;; Blackbox mode is suitable only for specially formatted data.

Re: Patch: minor blackbox.el fix

[Glenn Morris]

Tom Tromey wrote:

> This patch adds a "q" key binding to blackbox, to bury the buffer.

OK.

> Also, locally I found that RET was doing the wrong thing in blackbox,
> and this patch arranges to redefine newline-and-indent as well.

How is it that RET runs newline-and-indent and indent for you? Have
you globally rebound it? Would changing from blackbox-redefine-key to

(define-key map [return] 'bb-done)

be better than adding a binding for newline-and-indent?

> +    (define-key map "q" 'bury-buffer)
>      (blackbox-redefine-key map 'newline 'bb-done)
> +    (blackbox-redefine-key map 'newline-and-indent 'bb-done)

Re: Patch: minor blackbox.el fix

[Tom Tromey]

>>>>> "GM" == Glenn Morris <rgm@gnu.org> writes:

>> Also, locally I found that RET was doing the wrong thing in blackbox,
>> and this patch arranges to redefine newline-and-indent as well.

GM> How is it that RET runs newline-and-indent and indent for you? Have
GM> you globally rebound it? Would changing from blackbox-redefine-key to

Darn, I do have it bound globally, and I didn't think to look at that.
Sorry about that.

GM> (define-key map [return] 'bb-done)
GM> be better than adding a binding for newline-and-indent?

Yes, I think that would be better.

Thanks for reviewing this.

Tom

Re: Patch: minor blackbox.el fix

[Tom Tromey]

GM> (define-key map [return] 'bb-done)
GM> be better than adding a binding for newline-and-indent?

I neglected to send the updated patch.
Here it is.

Tom

2008-01-08  Tom Tromey  <tromey@redhat.com>

	* play/blackbox.el (blackbox-mode-map): Bind [return] and "q".

Index: lisp/play/blackbox.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/play/blackbox.el,v
retrieving revision 1.28
diff -u -r1.28 blackbox.el
--- lisp/play/blackbox.el	8 Jan 2008 20:44:08 -0000	1.28
+++ lisp/play/blackbox.el	9 Jan 2008 01:18:27 -0000
@@ -107,6 +107,8 @@
     (blackbox-redefine-key map 'move-beginning-of-line 'bb-bol)
     (define-key map " " 'bb-romp)
     (define-key map [insert] 'bb-romp)
+    (define-key map "q" 'bury-buffer)
+    (define-key map [return] 'bb-done)
     (blackbox-redefine-key map 'newline 'bb-done)
     map))