unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Daiki Ueno <ueno@unixuser.org>
To: wahjava.ml@gmail.com (Ashish SHUKLA)
Cc: Daniel Dehennin <daniel.dehennin@baby-gnu.org>, emacs-devel@gnu.org
Subject: Re: Gnus + GPG integration broken after revision 102412.
Date: Wed, 22 Dec 2010 14:21:45 +0900	[thread overview]
Message-ID: <m31v5abcwm.fsf-ueno@unixuser.org> (raw)
In-Reply-To: <86hbe679gs.fsf@chateau.d.if> (Ashish SHUKLA's message of "Wed, 22 Dec 2010 09:19:39 +0530")

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

wahjava.ml@gmail.com (Ashish SHUKLA) writes:

>> It looks strange that mml2015 passes the expired key to gpg, since
>> `mml2015-epg-sign' is expected to reject such a key through
>> `mml2015-epg-find-usable-key'.
>
>> Do you see 1F2F8410762E5E74 key with:
>
>> (mml2015-epg-find-usable-key
>>  (epg-list-keys (epg-make-context 'OpenPGP) "1F2F8410762E5E74" t)
>>  'sign)
>
> Yes, I see that key. And, please note that it's not expired, it's revoked.

Aha, then it's indeed a bug of mml2015-epg-*.  Please try the attached
patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mml2015-revoked.patch --]
[-- Type: text/x-patch, Size: 668 bytes --]

=== modified file 'lisp/gnus/mml2015.el'
--- lisp/gnus/mml2015.el	2010-11-17 22:15:24 +0000
+++ lisp/gnus/mml2015.el	2010-12-22 05:16:41 +0000
@@ -957,7 +957,7 @@
 			   (mapcar
 			    (lambda (signer)
 			      (setq signer-key (mml2015-epg-find-usable-key
-						(epg-list-keys context signer t)
+						(epg-list-keys context signer)
 						'sign))
 			      (unless (or signer-key
 					  (y-or-n-p
@@ -1068,7 +1068,7 @@
 			     (mapcar
 			      (lambda (signer)
 				(setq signer-key (mml2015-epg-find-usable-key
-						  (epg-list-keys context signer t)
+						  (epg-list-keys context signer)
 						  'sign))
 				(unless (or signer-key
 					    (y-or-n-p


[-- Attachment #3: Type: text/plain, Size: 145 bytes --]


Since I'm personally not confident if the fix is the right way, the
actual fix will be done after asking the gpg list.

Regards,
-- 
Daiki Ueno

  reply	other threads:[~2010-12-22  5:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20  8:54 Gnus + GPG integration broken after revision 102412 Ashish SHUKLA
2010-12-21  1:32 ` Daiki Ueno
2010-12-21 11:06   ` Ashish SHUKLA
2010-12-21 17:53     ` Daniel Dehennin
2010-12-21 22:51       ` Ashish SHUKLA
2010-12-22  1:31     ` Daiki Ueno
2010-12-22  3:49       ` Ashish SHUKLA
2010-12-22  5:21         ` Daiki Ueno [this message]
2010-12-22  6:56           ` Ashish SHUKLA
2010-12-22  8:29         ` Daniel Dehennin
2010-12-23  3:12           ` Ashish SHUKLA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31v5abcwm.fsf-ueno@unixuser.org \
    --to=ueno@unixuser.org \
    --cc=daniel.dehennin@baby-gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=wahjava.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).