* issue of smtpmail-via-smtp
@ 2011-07-05 3:29 Binjo
2011-07-05 11:29 ` Christoph Scholtes
0 siblings, 1 reply; 6+ messages in thread
From: Binjo @ 2011-07-05 3:29 UTC (permalink / raw)
To: emacs-devel
hi,
i'm using the latest no gnus and gnu emacs 24 under windows, with gnutls
enabled. the following changes allows me to send mail as usual, it turns out
`network-stream-get-response' will wait for the ":end-of-command" infinitly,
when searching for "^[0-9]+ .*\r\n". should there be a timeout check?
this change just works for me, i'm no expert of gnus/smtpmail protocol, so
please verify this, thanks.
binjo
diff --git a/lisp/mail/smtpmail.el b/lisp/mail/smtpmail.el
index b168506..a92b54f 100644
--- a/lisp/mail/smtpmail.el
+++ b/lisp/mail/smtpmail.el
@@ -622,14 +622,14 @@ The list is in preference order.")
"smtpmail" process-buffer host port
:type smtpmail-stream-type
:return-list t
- :capability-command (format "EHLO %s\r\n" (smtpmail-fqdn))
- :end-of-command "^[0-9]+ .*\r\n"
+ :capability-command (format "EHLO %s\n" (smtpmail-fqdn))
+ :end-of-command "^[0-9]+ .*\n"
:success "^2.*\n"
:always-query-capabilities t
:starttls-function
(lambda (capabilities)
(and (string-match "-STARTTLS" capabilities)
- "STARTTLS\r\n"))
+ "STARTTLS\n"))
:client-certificate t
:use-starttls-if-possible t))
@@ -664,7 +664,7 @@ The list is in preference order.")
""
(split-string
(plist-get (cdr result) :capabilities)
- "\r\n")))
+ "\n")))
(let ((name
(with-case-table ascii-case-table
(mapcar (lambda (s) (intern (downcase s)))
@@ -812,7 +812,7 @@ The list is in preference order.")
(catch 'done
(while response-continue
(goto-char smtpmail-read-point)
- (while (not (search-forward "\r\n" nil t))
+ (while (not (search-forward "\n" nil t))
(unless (memq (process-status process) '(open run))
(throw 'done nil))
(accept-process-output process)
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: issue of smtpmail-via-smtp
2011-07-05 3:29 issue of smtpmail-via-smtp Binjo
@ 2011-07-05 11:29 ` Christoph Scholtes
2011-07-05 13:40 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Scholtes @ 2011-07-05 11:29 UTC (permalink / raw)
To: Binjo; +Cc: Lars Magne Ingebrigtsen, emacs-devel
On 7/4/2011 9:29 PM, Binjo wrote:
> i'm using the latest no gnus and gnu emacs 24 under windows, with gnutls
> enabled. the following changes allows me to send mail as usual, it turns out
> `network-stream-get-response' will wait for the ":end-of-command" infinitly,
> when searching for "^[0-9]+ .*\r\n". should there be a timeout check?
Did you compile Emacs 24 from the trunk or a re you using the weekly
binary build?
Lars may want to confirm this, but this issue was fixed not too long in
the trunk and the dependency on platform specific line endings was removed:
revno: 104742
committer: Lars Magne Ingebrigtsen <larsi@gnus.org>
branch nick: trunk
timestamp: Mon 2011-06-27 02:02:15 +0200
message:
Bind coding-system-for-* to binary to possibly avoid line encoding
issues on Windows (among other things).
This might not have made it into the weekly binary build yet.
Christoph
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: issue of smtpmail-via-smtp
2011-07-05 11:29 ` Christoph Scholtes
@ 2011-07-05 13:40 ` Lars Magne Ingebrigtsen
2011-07-06 0:55 ` Binjo
0 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-05 13:40 UTC (permalink / raw)
To: Christoph Scholtes; +Cc: Binjo, emacs-devel
Christoph Scholtes <cschol2112@googlemail.com> writes:
> This might not have made it into the weekly binary build yet.
The weekly binary build seems to have the fix, but is the user using the
latest build?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: issue of smtpmail-via-smtp
2011-07-05 13:40 ` Lars Magne Ingebrigtsen
@ 2011-07-06 0:55 ` Binjo
2011-07-06 1:10 ` Christoph Scholtes
0 siblings, 1 reply; 6+ messages in thread
From: Binjo @ 2011-07-06 0:55 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: Christoph Scholtes, emacs-devel
On 07/05/2011, at 21:40, Lars Magne Ingebrigtsen wrote:
>Christoph Scholtes <cschol2112@googlemail.com> writes:
>
>> This might not have made it into the weekly binary build yet.
>
>The weekly binary build seems to have the fix, but is the user using the
>latest build?
i'm using the latest git repo, git://github.com/emacsmirror/emacs.git, so it's
the sync issue, the trunk is fixed? that would be great. xDD
thanks Christoph Scholtes and Lars Magne Ingebrigtsen.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: issue of smtpmail-via-smtp
2011-07-06 0:55 ` Binjo
@ 2011-07-06 1:10 ` Christoph Scholtes
2011-07-06 1:28 ` Binjo
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Scholtes @ 2011-07-06 1:10 UTC (permalink / raw)
To: Binjo; +Cc: Lars Magne Ingebrigtsen, emacs-devel
On 7/5/2011 6:55 PM, Binjo wrote:
> i'm using the latest git repo, git://github.com/emacsmirror/emacs.git, so it's
> the sync issue, the trunk is fixed? that would be great. xDD
Yes. It looks like the git repo has not been updated since the 22nd of
June. The issue was fixed in the trunk on the 27th of June.
Christoph
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: issue of smtpmail-via-smtp
2011-07-06 1:10 ` Christoph Scholtes
@ 2011-07-06 1:28 ` Binjo
0 siblings, 0 replies; 6+ messages in thread
From: Binjo @ 2011-07-06 1:28 UTC (permalink / raw)
To: Christoph Scholtes; +Cc: emacs-devel
On 07/06/2011, at 09:10, Christoph Scholtes wrote:
>On 7/5/2011 6:55 PM, Binjo wrote:
>> i'm using the latest git repo, git://github.com/emacsmirror/emacs.git, so it's
>> the sync issue, the trunk is fixed? that would be great. xDD
>
>Yes. It looks like the git repo has not been updated since the 22nd of
>June. The issue was fixed in the trunk on the 27th of June.
>
>Christoph
thanks for the confirmation.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-06 1:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-05 3:29 issue of smtpmail-via-smtp Binjo
2011-07-05 11:29 ` Christoph Scholtes
2011-07-05 13:40 ` Lars Magne Ingebrigtsen
2011-07-06 0:55 ` Binjo
2011-07-06 1:10 ` Christoph Scholtes
2011-07-06 1:28 ` Binjo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).