From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: pcomplete Date: Mon, 17 Jun 2019 15:30:44 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="156701"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 17 15:31:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcrjM-000ee6-GX for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 15:31:28 +0200 Original-Received: from localhost ([::1]:47554 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcrjL-0007um-HS for ged-emacs-devel@m.gmane.org; Mon, 17 Jun 2019 09:31:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57140) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcrip-0007tn-GZ for emacs-devel@gnu.org; Mon, 17 Jun 2019 09:30:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcrin-00044W-Fw for emacs-devel@gnu.org; Mon, 17 Jun 2019 09:30:55 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:40660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcril-00041p-IK for emacs-devel@gnu.org; Mon, 17 Jun 2019 09:30:53 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcrie-00057l-Av; Mon, 17 Jun 2019 15:30:48 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBgXW1tZkY2IYFxYF AwMKCAdn2ceNAAACZ0lEQVQ4jU2UTW7jMAyFido6gBR0X0vw3hbLvYEqe44V3v8q8yg7nVFTBdZn /j1SIVK7Vjc1nZ/vJyIj68yCDc+thQsw+ZZzZnYopE9T9Vfxn6OvFFORvRjcuVknO3NeBoq51GKE 83aETn1PufpxWVLpQkQADYCX5CapGDY4usBhxAVhgTJA9PAEZzNAXyl0kLL9ifFhPG2v2YMQiyKx vHy2Halx51VnIgCvxoM/6I8nxozEyEKgwNY93bTuvos82AL+iKoZjlCC4yKGnN0LaQ12elirOSbV gAQGCP7ZI7ToCPU9/3zaIEQBup9woUGW+DWH1Uyqg6EyTfxqanmlA08Znv28s1bh0D7wsueve3yM fuiJV8KTP1LNW3uGnisP4IUklyouaYPvDlkdQCposY2WPMhbi/KFPOMa13mGVYxfDUKNuKQ0h5q+ 27GXKcbt1Q4aVuSrFmnPpXBFgVfFNzgXzEmFslncz5DcG0lnLLxAx1zYg2q4QfuA3NYFBsJK18gB zMd0z0+UcRJuUDX8D2xM7QAr+QhhUCLEUm/rbfFFOQuGEPXae9gZ4Oe7hVrdz/kPdIDDx2iA/gtw DXwhDYFyPZe3Ix7gOMI03h0bOt1LYZJA7Zj0bXdZFHSwozWtKwYWV0WuCThzqmQzOhDa62gULrMu veRCrq9SQ3Z0LTcpMV/fFcJWXAVov3qMeAOokR8AvtaJx8EAfK8y7nQw4ZrorjRM5ZKKaBOBa7pr wowyq19OpId48RfcQ4yhaZwfHGk+/JoiV72aBEV7Zlj4D4Ff7G1oMcMVWRUA+LyWmuAXBpVrPyH0 Xwhi31X7JUg5AAAAAElFTkSuQmCC In-Reply-To: (Lars Ingebrigtsen's message of "Mon, 17 Jun 2019 14:08:49 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237784 Archived-At: Lars Ingebrigtsen writes: > Am I misreading the code? Nope. A change in 2011 changed - (setq pcomplete-suffix-list (cons ?= pcomplete-suffix-list)) to + (let ((pcomplete-suffix-list (cons ?= pcomplete-suffix-list))) But the pcomplete function binds that variable, so the call to pcomplete/tar alters the value, and then when the pcomplete function later calls pcomplete-insert-entry, it does the right thing. So this has been buggy since 2011. :-) The bug is that when you call M-x pcomplete now, tar --rsh-command= but with the setq it's: tar --rsh-command= It's the same with the standard completion function -- there's a space after the = sign after hitting TAB, which is a bug... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no