From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Type-error in C code Date: Mon, 15 Nov 2010 22:19:30 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1289856644 11181 80.91.229.12 (15 Nov 2010 21:30:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 15 Nov 2010 21:30:44 +0000 (UTC) Cc: Julien Danjou , Jan =?utf-8?Q?Dj=C3=A4rv?= , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 15 22:30:39 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PI6dK-0004G7-UX for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2010 22:30:39 +0100 Original-Received: from localhost ([127.0.0.1]:51284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI6dK-0002cX-3n for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2010 16:30:38 -0500 Original-Received: from [140.186.70.92] (port=34980 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI6Sh-00060f-V6 for emacs-devel@gnu.org; Mon, 15 Nov 2010 16:19:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI6Sc-0006rU-DJ for emacs-devel@gnu.org; Mon, 15 Nov 2010 16:19:38 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.10]:40080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI6Sc-0006rH-8H for emacs-devel@gnu.org; Mon, 15 Nov 2010 16:19:34 -0500 Original-Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 97A9018010F5; Mon, 15 Nov 2010 22:19:31 +0100 (CET) Original-Received: from igel.home (ppp-88-217-124-96.dynamic.mnet-online.de [88.217.124.96]) by mail.mnet-online.de (Postfix) with ESMTP id 63C7C1C00262; Mon, 15 Nov 2010 22:19:31 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 501) id EA8F0CA2A0; Mon, 15 Nov 2010 22:19:30 +0100 (CET) X-Yow: NANCY!! Why is everything RED?! In-Reply-To: (Stefan Monnier's message of "Fri, 12 Nov 2010 16:00:15 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.90 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132661 Archived-At: Stefan Monnier writes: >>> The error is to put an "Atom" into a cons cell: those can only hold >>> Lisp_Objects. The usual compilation flags won't catch the error because >>> both types are actually some kind of integer, but if you >>> compile --enable-use-lisp-union-type, the C compiler will >>> dutyfully burp. > >> I think we should remove the union Lisp_Object, and instead define a >> struct Lisp_Object { EMACS_INT i; } (reusing the macros of the non-union >> type), and make that the default Lisp_Object at least during >> development. > > Not sure what we be the benefit. Let the compiler burp. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."