From: Dave Abrahams <dave@boostpro.com>
To: Chong Yidong <cyd@gnu.org>
Cc: joakim@verona.se, emacs-devel@gnu.org
Subject: Re: Policy for backwards-incompatible changes?
Date: Mon, 31 Oct 2011 11:13:21 -0800 [thread overview]
Message-ID: <m2zkgh3rfy.fsf@boostpro.com> (raw)
In-Reply-To: <877h3tzpaz.fsf@gnu.org> (Chong Yidong's message of "Tue, 25 Oct 2011 12:08:04 +0800")
on Mon Oct 24 2011, Chong Yidong <cyd-AT-gnu.org> wrote:
> Dave Abrahams <dave@boostpro.com> writes:
>
>> This, and the fact that I've received no other answers, support my
>> suspicion that the design of themes may not be working well for the
>> user community. As far as I can tell, the only thing required to make
>> themes work as you and I would want them to would be to give the
>> "user" (i.e. default) theme lowest priority rather than highest.
>>
>> But this is a fairly radical change to make silently. What would need
>> to happen before something like that could be done?
>
> One would have to fix the Customize interface, which currently assumes
> that the user theme takes precedence over themed variables (e.g. it
> marks themed but not customized variables as THEMED).
>
> If that is fixed, I think the way to handle the theme and Customize
> interaction is to add the `user' theme to the custom-enabled-themes
> variable, so that it is treated on a similar footing to themes---the
> user can explicitly specify their relative priorities.
So it would be automatically inserted at the front of the list if it
wasn't already there, as a way to preserve backward compatibility. I
like it!
However, we would still be breaking backward compatibility in that
enabling a theme with a setting already in the "user" theme would
now override that setting. If that doesn't bother anyone, I'm happy
with it.
> (The `custom-enabled-themes' variable itself would have to be treated
> specially, of course, but that's also the case currently; you can set
> it from a theme.)
>
> The commands like `load-theme', if called interactively, could prompt
> for whether or not to override the `user' theme.
So it sounds like you would be open to accepting a patch that would
implement this?
--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
next prev parent reply other threads:[~2011-10-31 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 9:18 customization theme users/use-cases/info Dave Abrahams
2011-10-21 13:42 ` joakim
2011-10-23 17:09 ` Policy for backwards-incompatible changes? (was: customization theme users/use-cases/info) Dave Abrahams
2011-10-25 4:08 ` Policy for backwards-incompatible changes? Chong Yidong
2011-10-31 19:13 ` Dave Abrahams [this message]
2011-11-06 6:48 ` Chong Yidong
2011-10-25 4:10 ` customization theme users/use-cases/info Chong Yidong
2011-10-31 19:42 ` Dave Abrahams
2011-11-06 6:45 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zkgh3rfy.fsf@boostpro.com \
--to=dave@boostpro.com \
--cc=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).