unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Wiegley <jwiegley@gmail.com>
To: foudfou <foudil.newbie@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region.
Date: Mon, 14 Dec 2015 10:29:29 -0800	[thread overview]
Message-ID: <m2zixcriie.fsf@newartisans.com> (raw)
In-Reply-To: <83zixd2aw4.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 14 Dec 2015 19:33:15 +0200")

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

>> This is what this patch is about. It doesn't change previous behaviors, and
>> just adds the ability to select with the region. For the sake of simplicity,
>> I didn't modify current menu labels, the mode's help, nor renamed the
>> impacted functions.

> Could someone who uses ibuffer.el please look into this patch and provide
> comments?

Foudil, why does this patch rely on the use of the region to select a group of
buffers, rather than the existing functionality of using 'm' to mark buffer(s)
for subsequent action? This is a pattern used by many other modes, such as
dired.

In my brief testing, dired does not allow aggregate actions based on regions
either. Therefore, since ibuffer advertises itself as "a dired for buffers" --
and likewise, proced for processes -- the method for dealing with aggregate
targets should be kept consistent.

Thus, I'm inclined to reject this patch in favor of the existing "marking"
methodology.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

  reply	other threads:[~2015-12-14 18:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-12 21:45 [PATCH] * lisp/ibuffer.el: Add ability to (un-)mark or delete buffers in the region foudfou
2015-12-14 17:33 ` Eli Zaretskii
2015-12-14 18:29   ` John Wiegley [this message]
2015-12-14 19:10     ` Drew Adams
2015-12-14 19:52       ` [PATCH] * lisp/ibuffer.el: Add ability to (nu-)mark " John Wiegley
2015-12-14 20:07         ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2zixcriie.fsf@newartisans.com \
    --to=jwiegley@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=foudil.newbie@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).