From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Wiegley Newsgroups: gmane.emacs.devel Subject: Re: Small docstring improvements Date: Fri, 19 Aug 2016 14:12:50 -0700 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1471641228 14219 195.159.176.226 (19 Aug 2016 21:13:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 19 Aug 2016 21:13:48 +0000 (UTC) User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1 (darwin) Cc: Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 19 23:13:43 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bar6k-0003ME-1G for ged-emacs-devel@m.gmane.org; Fri, 19 Aug 2016 23:13:42 +0200 Original-Received: from localhost ([::1]:58999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bar6k-0004KD-7w for ged-emacs-devel@m.gmane.org; Fri, 19 Aug 2016 17:13:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bar64-0004CL-QP for emacs-devel@gnu.org; Fri, 19 Aug 2016 17:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bar5y-0000r2-Nn for emacs-devel@gnu.org; Fri, 19 Aug 2016 17:13:00 -0400 Original-Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]:35138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bar5y-0000qw-G6 for emacs-devel@gnu.org; Fri, 19 Aug 2016 17:12:54 -0400 Original-Received: by mail-pa0-x233.google.com with SMTP id hb8so808680pac.2 for ; Fri, 19 Aug 2016 14:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:mail-followup-to:date:in-reply-to :message-id:user-agent:mime-version; bh=QVZsWO5FGFOzjGuLUdlpbMZoQkZFCb9Zf8wzrSVpY4c=; b=jLe9BY1PRI0e2c95H6KKEU7nPH67KLQDKzy4F1jGO7trPMOkWpaVJxhMXdcKOYizDB nkVuVJjTaAat3ZziIEzByMr3buQTRIk5iMvetPEb/0hWX+CGrkiOVktg2iJXe4A7KzYQ /5rXBxOecLKZ9S1/1fZyl6ZXpq+/7bhpWaDfhOMZLazsdrLneWBgVxrFrDWiCd95BWYy rsoAnAnduFBZJxvr7uQ8tR8TTJnAFijROGdDOyhp4KXXAUPxOVoWnZkkAoOfnkcMyUnw QuTWlzJJ1olSIyYwAPjYw8j/dIE2SgapjTx0MwbjHaCLY8gbjH4wWesVCr9MeQUQMuFT qsgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :date:in-reply-to:message-id:user-agent:mime-version; bh=QVZsWO5FGFOzjGuLUdlpbMZoQkZFCb9Zf8wzrSVpY4c=; b=GTifpZurROaxTact39uuunZ9ER8SmUiJvD6Laxlr0WStwfcjYFSo71vHSyWPLUsUbQ TwzAu+zNk3cE1iPRZexjHoy1CwzD/nOqxormb0H2r//ltw2ZFyOOXD4Wid2xP/czZon7 1I3VG4bbH7vgQFJqRXnxlYoMUPeBN1fgKCRTzLaXUwXnEKMW52Fn/ztDNZ606EaCnhCX e14hblTDwOtaU9tCLrNzeZ6byjo30mDF6m/ReyT1HjEjshjcWE3hUdNgsadU6XF1pNgg FEnhL+VGANmrV750KzCSOFw+1ob7+6eEVxXPoxME87Ra+2ZN9z8h5FmMT+eFP+ev14kB LLrQ== X-Gm-Message-State: AEkoousgQlZbxs1hkQCPubfeu1BSIQXUf8V49yNvsPAMKMkvjUcv5AZC0ZqmzzH7mYoiCw== X-Received: by 10.66.148.202 with SMTP id tu10mr17344640pab.52.1471641173668; Fri, 19 Aug 2016 14:12:53 -0700 (PDT) Original-Received: from Vulcan.local (76-234-69-149.lightspeed.frokca.sbcglobal.net. [76.234.69.149]) by smtp.gmail.com with ESMTPSA id y6sm13733063pav.1.2016.08.19.14.12.51 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 19 Aug 2016 14:12:52 -0700 (PDT) X-Google-Original-From: "John Wiegley" Original-Received: by Vulcan.local (Postfix, from userid 501) id BFE4920579EA; Fri, 19 Aug 2016 14:12:50 -0700 (PDT) Mail-Followup-To: Philipp Stephani , Emacs developers In-Reply-To: (Philipp Stephani's message of "Fri, 19 Aug 2016 20:34:58 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206688 Archived-At: >>>>> "PS" == Philipp Stephani writes: PS> I've simply copied the docstring from write-region, which has exactly the PS> same semantics (because call-process-region calls write-region). Like it PS> or not, these are the semantics, and they are intentional (the code for PS> call-process-region has explicit branches for these cases), so I think PS> they deserve to be documented. Yes, agreed with respect to your patch, disagree only with respect to what you found there. :) Those explicit branches shouldn't have been written. It sounds like its purely an attempt to avoid creating new functions for what is clearly new functionality. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2