From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: Re: master e4896fc 1/2: Add a new 'flex' completion style
Date: Thu, 14 Feb 2019 13:38:50 +0100 [thread overview]
Message-ID: <m2zhqyzgrp.fsf@gmail.com> (raw)
In-Reply-To: <20190213212414.D6F4C209C6@vcs0.savannah.gnu.org> (unknown@unknown.invalid's message of "Wed, 13 Feb 2019 16:24:14 -0500 (EST)")
Unknown <unknown@unknown.invalid> writes:
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index b757eb8..c1e3fdc 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -788,6 +788,11 @@ Additionally the user can use the char \"*\" as a glob pattern.")
> I.e. when completing \"foo_bar\" (where _ is the position of point),
> it will consider all completions candidates matching the glob
> pattern \"*foo*bar*\".")
> + (flex
> + completion-flex-try-completion completion-flex-all-completions
> + "Completion of an in-order subset of characters.
> +When completing \"foo\" the glob \"*f*o*o*\" is used, so that
> +i.e. foo can complete to frodo.")
I think you can either drop the 'i.e.', or drop 'so that'.
> (initials
> completion-initials-try-completion completion-initials-all-completions
> "Completion of acronyms and initialisms.
> @@ -3345,7 +3350,12 @@ the same set of elements."
> ;;; Substring completion
> ;; Mostly derived from the code of `basic' completion.
>
> -(defun completion-substring--all-completions (string table pred point)
> +(defun completion-substring--all-completions
> + (string table pred point &optional transform-pattern-fn)
> + "Match the presumed substring STRING to the entries in TABLE.
> +Respect PRED and POINT. The pattern used is a PCM-style
> +substring pattern, but it be massaged by TRANSFORM-PATTERN-FN, if
> +that is non-nil."
Iʼm all in favour of respect, but what does that mean in the context
of PRED and POINT?
What is 'PCM-style'? What does 'massaged' mean? What is the signature of
TRANSFORM-PATTERN-FN?
Robert
next parent reply other threads:[~2019-02-14 12:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190213212413.868.40960@vcs0.savannah.gnu.org>
[not found] ` <20190213212414.D6F4C209C6@vcs0.savannah.gnu.org>
2019-02-14 12:38 ` Robert Pluim [this message]
2019-02-14 13:50 ` master e4896fc 1/2: Add a new 'flex' completion style João Távora
2019-02-14 14:37 ` Eli Zaretskii
2019-02-14 14:40 ` João Távora
2019-02-14 14:47 ` Robert Pluim
2019-02-14 14:50 ` João Távora
2019-02-14 15:12 ` Robert Pluim
2019-02-14 15:22 ` Drew Adams
2019-02-14 14:29 ` Eli Zaretskii
2019-02-14 14:39 ` João Távora
[not found] ` <20190213212415.148B9209D7@vcs0.savannah.gnu.org>
2019-03-16 1:13 ` [Emacs-diffs] master b0e318d 2/2: Score flex-style completions according to match tightness Dmitry Gutov
2019-03-16 13:02 ` João Távora
2019-03-16 13:19 ` Stefan Monnier
2019-03-16 14:25 ` João Távora
2019-03-17 18:06 ` Dmitry Gutov
2019-03-17 19:22 ` João Távora
2019-03-17 20:32 ` Dmitry Gutov
2019-03-17 21:46 ` João Távora
2019-03-18 14:26 ` Dmitry Gutov
2019-03-18 14:42 ` Dmitry Gutov
2019-03-18 14:49 ` Stefan Monnier
2019-03-18 14:52 ` Dmitry Gutov
2019-03-18 16:20 ` Stefan Monnier
2019-03-18 15:13 ` Who uses Icomplete-mode? " João Távora
2019-03-18 16:44 ` Stefan Monnier
2019-03-18 21:08 ` Who uses Icomplete-mode? Juri Linkov
2019-03-18 14:54 ` [Emacs-diffs] master b0e318d 2/2: Score flex-style completions according to match tightness João Távora
2019-03-18 14:51 ` João Távora
2019-03-18 17:18 ` Dmitry Gutov
2019-03-20 9:59 ` João Távora
2019-03-20 12:09 ` Stefan Monnier
2019-03-20 21:00 ` João Távora
2019-03-20 21:58 ` Dmitry Gutov
2019-03-20 23:25 ` João Távora
2019-03-21 1:14 ` Stefan Monnier
2019-03-21 1:20 ` Dmitry Gutov
2019-03-21 1:08 ` Stefan Monnier
2019-03-17 17:51 ` Dmitry Gutov
2019-03-17 19:09 ` João Távora
2019-03-17 20:22 ` Dmitry Gutov
2019-03-17 21:27 ` João Távora
2019-03-18 0:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zhqyzgrp.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).