* Re: master 6daa695: * lisp/gnus/gnus-art.el: Use mail-header-p
[not found] ` <20190528191049.63CE3209A7@vcs0.savannah.gnu.org>
@ 2019-05-29 7:57 ` Robert Pluim
2019-05-29 9:10 ` Robert Pluim
0 siblings, 1 reply; 2+ messages in thread
From: Robert Pluim @ 2019-05-29 7:57 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
>>>>> On Tue, 28 May 2019 15:10:48 -0400 (EDT), monnier@iro.umontreal.ca (Stefan Monnier) said:
Stefan> branch: master
Stefan> commit 6daa69576af6a702b8cf3d57b4831a117b4bc311
Stefan> Author: Stefan Monnier <monnier@iro.umontreal.ca>
Stefan> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
Stefan> * lisp/gnus/gnus-art.el: Use mail-header-p
I guess that needs something like the following (untested) as well.
diff --git a/lisp/gnus/nnheader.el b/lisp/gnus/nnheader.el
index 6ef324ae91..981853fd97 100644
--- a/lisp/gnus/nnheader.el
+++ b/lisp/gnus/nnheader.el
@@ -135,7 +135,6 @@ nnheader-directory-separator-character
;; (That next-to-last entry is defined as "misc" in the NOV format,
;; but Gnus uses it for xrefs.)
-(defalias 'mail-header-p #'vectorp) ;For lack of tag, it's all we have.
(cl-defstruct (mail-header
(:type vector)
(:constructor nil)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: master 6daa695: * lisp/gnus/gnus-art.el: Use mail-header-p
2019-05-29 7:57 ` master 6daa695: * lisp/gnus/gnus-art.el: Use mail-header-p Robert Pluim
@ 2019-05-29 9:10 ` Robert Pluim
0 siblings, 0 replies; 2+ messages in thread
From: Robert Pluim @ 2019-05-29 9:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
>>>>> On Wed, 29 May 2019 09:57:39 +0200, Robert Pluim <rpluim@gmail.com> said:
>>>>> On Tue, 28 May 2019 15:10:48 -0400 (EDT), monnier@iro.umontreal.ca (Stefan Monnier) said:
Stefan> branch: master
Stefan> commit 6daa69576af6a702b8cf3d57b4831a117b4bc311
Stefan> Author: Stefan Monnier <monnier@iro.umontreal.ca>
Stefan> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
Stefan> * lisp/gnus/gnus-art.el: Use mail-header-p
Robert> I guess that needs something like the following (untested) as well.
No it doesnʼt, that totally breaks gnus. I guess I shouldn't have
believed the cl-defstruct doc string (or it should mention that this
doesnʼt work when using :type vector).
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-29 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190528191047.3260.4480@vcs0.savannah.gnu.org>
[not found] ` <20190528191049.63CE3209A7@vcs0.savannah.gnu.org>
2019-05-29 7:57 ` master 6daa695: * lisp/gnus/gnus-art.el: Use mail-header-p Robert Pluim
2019-05-29 9:10 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).