unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Calendar window height bug?
@ 2007-07-27 19:51 Leo
  2007-07-29 20:49 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Leo @ 2007-07-27 19:51 UTC (permalink / raw)
  To: emacs-devel

Hi all,

[GNU Emacs 23.0.0.4 (i686-pc-linux-gnu, GTK+ Version 2.10.14) of 2007-07-27]

The following change in calendar-basic-setup is problematic as now the
calendar window is not adjusted to fit the buffer.

--8<---------------cut here---------------start------------->8---
--- 1.el	2007-07-27 20:42:18.970945486 +0100
+++ 2.el	2007-07-27 20:42:51.965911897 +0100
@@ -53,9 +53,11 @@
     ;; (calendar-read-date t) returns a date with day = nil, which is
     ;; not a legal date for the visible test in the diary section.
     (if arg (setcar (cdr date) 1))
-    (pop-to-buffer calendar-buffer)
     (increment-calendar-month month year (- calendar-offset))
     (generate-calendar-window month year)
+    ;; Display the buffer *after* generating it, so that menu entries that
+    ;; use display-month do not fail when creating the new frame.
+    (pop-to-buffer calendar-buffer)
     (if (and view-diary-entries-initially (calendar-date-is-visible-p date))
         (diary-view-entries)))
   (let* ((diary-buffer (get-file-buffer diary-file))
--8<---------------cut here---------------end--------------->8---

HTH,
-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Calendar window height bug?
  2007-07-27 19:51 Calendar window height bug? Leo
@ 2007-07-29 20:49 ` Stefan Monnier
  2007-07-29 21:57   ` Leo
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2007-07-29 20:49 UTC (permalink / raw)
  To: Leo; +Cc: emacs-devel

> Hi all,
> [GNU Emacs 23.0.0.4 (i686-pc-linux-gnu, GTK+ Version 2.10.14) of 2007-07-27]

> The following change in calendar-basic-setup is problematic as now the
> calendar window is not adjusted to fit the buffer.

I believe I've now fixed it in the trunk.


        Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Calendar window height bug?
  2007-07-29 20:49 ` Stefan Monnier
@ 2007-07-29 21:57   ` Leo
  0 siblings, 0 replies; 3+ messages in thread
From: Leo @ 2007-07-29 21:57 UTC (permalink / raw)
  To: emacs-devel

On 2007-07-29 21:49 +0100, Stefan Monnier wrote:
>> Hi all,
>> [GNU Emacs 23.0.0.4 (i686-pc-linux-gnu, GTK+ Version 2.10.14) of 2007-07-27]
>
>> The following change in calendar-basic-setup is problematic as now the
>> calendar window is not adjusted to fit the buffer.
>
> I believe I've now fixed it in the trunk.
>
>
>         Stefan

Confirmed!

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-29 21:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-27 19:51 Calendar window height bug? Leo
2007-07-29 20:49 ` Stefan Monnier
2007-07-29 21:57   ` Leo

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).