From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: ido regression in trunk? Date: Fri, 28 Sep 2012 11:33:20 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348803217 26819 80.91.229.3 (28 Sep 2012 03:33:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Sep 2012 03:33:37 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 28 05:33:43 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1THRKg-0007WZ-1M for ged-emacs-devel@m.gmane.org; Fri, 28 Sep 2012 05:33:42 +0200 Original-Received: from localhost ([::1]:36580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THRKa-0003jY-PZ for ged-emacs-devel@m.gmane.org; Thu, 27 Sep 2012 23:33:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THRKX-0003jT-AQ for emacs-devel@gnu.org; Thu, 27 Sep 2012 23:33:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THRKW-0007Qo-4B for emacs-devel@gnu.org; Thu, 27 Sep 2012 23:33:33 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:54044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THRKV-0007Qk-TK for emacs-devel@gnu.org; Thu, 27 Sep 2012 23:33:32 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1THRKZ-0007TK-Of for emacs-devel@gnu.org; Fri, 28 Sep 2012 05:33:35 +0200 Original-Received: from 119.255.41.67 ([119.255.41.67]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 28 Sep 2012 05:33:35 +0200 Original-Received: from sdl.web by 119.255.41.67 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 28 Sep 2012 05:33:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 119.255.41.67 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (OS X 10.8.2) Cancel-Lock: sha1:ez7wxmiRTQpHGpkOBJmlLlD2Rco= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153654 Archived-At: On 2012-09-28 02:19 +0800, Carsten Mattner wrote: > Did anyone else notice that opening files with ido enabled > doesn't work as it did last week in current trunk? > > The fuzzy match of file/dir to open always open the first > item of the list even if I continue typing a more precise > different sub-directory which is not the first entry of the list. > > I cannot imagine this to go unnoticed. On 2012-09-28 07:05 +0800, Christopher Monsanto wrote: > I've noticed this problem as well, very irritating. If the maintainer > of ido doesn't know what's up, I can do a bisect to find the problem. > > Christopher Monsanto > chris@monsan.to -- http://monsan.to/ Sorry to all. It is my fault. I will install the following fix later today: diff --git a/lisp/ido.el b/lisp/ido.el index d48e7ba8..f511dbbf 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -3701,14 +3701,14 @@ (defun ido-set-matches-1 (items &optional do-full) (rexq (concat rex0 (if slash ".*/" ""))) (re (if ido-enable-prefix (concat "\\`" rexq) rexq)) (full-re (and do-full - (and (eq ido-cur-item 'buffer) - (not ido-buffer-disable-smart-matches)) + (not (and (eq ido-cur-item 'buffer) + ido-buffer-disable-smart-matches)) (not ido-enable-regexp) (not (string-match "\$\\'" rex0)) (concat "\\`" rex0 (if slash "/" "") "\\'"))) (suffix-re (and do-full slash - (and (eq ido-cur-item 'buffer) - (not ido-buffer-disable-smart-matches)) + (not (and (eq ido-cur-item 'buffer) + ido-buffer-disable-smart-matches)) (not ido-enable-regexp) (not (string-match "\$\\'" rex0)) (concat rex0 "/\\'")))