* Re: master 1f02cbe: Fix bug#21766 and add test
[not found] ` <E1ZrUTk-0006fS-Ib@vcs.savannah.gnu.org>
@ 2015-10-28 18:11 ` Artur Malabarba
2015-10-28 23:05 ` Juanma Barranquero
0 siblings, 1 reply; 3+ messages in thread
From: Artur Malabarba @ 2015-10-28 18:11 UTC (permalink / raw)
To: emacs-devel, Juanma Barranquero; +Cc: emacs-diffs
[-- Attachment #1.1: Type: text/plain, Size: 382 bytes --]
> Author: Juanma Barranquero <lekktu@gmail.com>
> Commit: Juanma Barranquero <lekktu@gmail.com>
>
> Fix bug#21766 and add test
>
> * lisp/simple.el (delete-trailing-whitespace): Save match data when
> calling `skip-syntax-backward'.
> * test/automated/simple-test.el (simple-delete-trailing-whitespace):
> New test.
Awesome. Thanks for adding a test with this!
[-- Attachment #1.2: Type: text/html, Size: 587 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1f02cbe: Fix bug#21766 and add test
2015-10-28 18:11 ` master 1f02cbe: Fix bug#21766 and add test Artur Malabarba
@ 2015-10-28 23:05 ` Juanma Barranquero
2015-10-29 1:45 ` [Emacs-diffs] " John Wiegley
0 siblings, 1 reply; 3+ messages in thread
From: Juanma Barranquero @ 2015-10-28 23:05 UTC (permalink / raw)
To: bruce.connor.am; +Cc: emacs-diffs, emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 279 bytes --]
On Wed, Oct 28, 2015 at 7:11 PM, Artur Malabarba <bruce.connor.am@gmail.com>
wrote:
> Thanks for adding a test with this!
Now that we have a testing framework, *all* bug fixes should have a test if
at all possible, IMO. (Of course there are bugs that cannot be easily
tested.)
[-- Attachment #1.2: Type: text/html, Size: 398 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 1f02cbe: Fix bug#21766 and add test
2015-10-28 23:05 ` Juanma Barranquero
@ 2015-10-29 1:45 ` John Wiegley
0 siblings, 0 replies; 3+ messages in thread
From: John Wiegley @ 2015-10-29 1:45 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: emacs-diffs, bruce.connor.am, emacs-devel
>>>>> Juanma Barranquero <lekktu@gmail.com> writes:
> Now that we have a testing framework, *all* bug fixes should have a test if
> at all possible, IMO. (Of course there are bugs that cannot be easily
> tested.)
Very much agreed, where feasible. However, it should not stop people from
submitting fixes, if for some reason they are unwilling to create a test. I
wouldn't want it to become a barrier to contribution.
John
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-29 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151028172540.25596.47811@vcs.savannah.gnu.org>
[not found] ` <E1ZrUTk-0006fS-Ib@vcs.savannah.gnu.org>
2015-10-28 18:11 ` master 1f02cbe: Fix bug#21766 and add test Artur Malabarba
2015-10-28 23:05 ` Juanma Barranquero
2015-10-29 1:45 ` [Emacs-diffs] " John Wiegley
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).