From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "John Wiegley" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type Date: Tue, 26 Dec 2017 10:49:39 -0800 Message-ID: References: <20171220063930.19227-1-vibhavp@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1514314116 19879 195.159.176.226 (26 Dec 2017 18:48:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 26 Dec 2017 18:48:36 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (darwin) Cc: Philipp Stephani , emacs-devel@gnu.org To: Vibhav Pant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 26 19:48:31 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eTuH8-0004ga-OH for ged-emacs-devel@m.gmane.org; Tue, 26 Dec 2017 19:48:30 +0100 Original-Received: from localhost ([::1]:52559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTuJ5-00044D-OR for ged-emacs-devel@m.gmane.org; Tue, 26 Dec 2017 13:50:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTuIQ-00042t-Ox for emacs-devel@gnu.org; Tue, 26 Dec 2017 13:49:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eTuIQ-00028T-1x for emacs-devel@gnu.org; Tue, 26 Dec 2017 13:49:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eTuIL-00023R-7h; Tue, 26 Dec 2017 13:49:45 -0500 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:55123) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1eTuIK-0004nK-Vd; Tue, 26 Dec 2017 13:49:45 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 7610820D53; Tue, 26 Dec 2017 13:49:43 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Tue, 26 Dec 2017 13:49:43 -0500 X-ME-Sender: Original-Received: from localhost (76-234-69-149.lightspeed.frokca.sbcglobal.net [76.234.69.149]) by mail.messagingengine.com (Postfix) with ESMTPA id 0DBC02442C; Tue, 26 Dec 2017 13:49:42 -0500 (EST) In-Reply-To: (Vibhav Pant's message of "Fri, 22 Dec 2017 19:02:31 +0530") Mail-Followup-To: Vibhav Pant , Philipp Stephani , emacs-devel@gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221419 Archived-At: >>>>> "VP" == Vibhav Pant writes: VP> Friendly ping, any feedback on this patch? I plan to submit another patch VP> to json.c, which makes use of this one. I approve of the patch, Vibhav. I'm suprised we don't have a SAFE_CALLOC macro, though, to avoid having to use memset immediately after. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2