From: "John Wiegley" <johnw@gnu.org>
To: Vibhav Pant <vibhavp@gmail.com>
Cc: Philipp Stephani <p.stephani2@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type
Date: Tue, 26 Dec 2017 10:49:39 -0800 [thread overview]
Message-ID: <m2y3lpnx30.fsf@newartisans.com> (raw)
In-Reply-To: <CA+T2Sh2wjSA5Vm-L5uvdPfF_w-WDGTdb_bep8_OFRDqdVwfE0A@mail.gmail.com> (Vibhav Pant's message of "Fri, 22 Dec 2017 19:02:31 +0530")
>>>>> "VP" == Vibhav Pant <vibhavp@gmail.com> writes:
VP> Friendly ping, any feedback on this patch? I plan to submit another patch
VP> to json.c, which makes use of this one.
I approve of the patch, Vibhav. I'm suprised we don't have a SAFE_CALLOC
macro, though, to avoid having to use memset immediately after.
--
John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2
next prev parent reply other threads:[~2017-12-26 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 6:39 [PATCH] Use get_key_arg to parse keyword arguments in json_parse_object_type Vibhav Pant
2017-12-22 13:32 ` Vibhav Pant
2017-12-26 18:49 ` John Wiegley [this message]
2017-12-26 19:11 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y3lpnx30.fsf@newartisans.com \
--to=johnw@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).