* Re: [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754) [not found] ` <20181008194827.A075520468@vcs0.savannah.gnu.org> @ 2018-10-08 20:08 ` Stefan Monnier 2018-10-09 18:17 ` Charles A. Roelli 0 siblings, 1 reply; 2+ messages in thread From: Stefan Monnier @ 2018-10-08 20:08 UTC (permalink / raw) To: Charles A. Roelli; +Cc: emacs-devel > +;;;###autoload > +(defcustom vc-retrieve-tag-hook nil Why autoload this? Autoloading variables is usually a bad idea, so unless there's a very good reason for it, we should remove this autoload cookie. Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754) 2018-10-08 20:08 ` [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754) Stefan Monnier @ 2018-10-09 18:17 ` Charles A. Roelli 0 siblings, 0 replies; 2+ messages in thread From: Charles A. Roelli @ 2018-10-09 18:17 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel > From: Stefan Monnier <monnier@iro.umontreal.ca> > Date: Mon, 08 Oct 2018 16:08:49 -0400 > > > +;;;###autoload > > +(defcustom vc-retrieve-tag-hook nil > > Why autoload this? Autoloading variables is usually a bad idea, so > unless there's a very good reason for it, we should remove this > autoload cookie. Ah, I see this is explained in the Elisp manual, "When to Autoload". I will remove the autoload, thanks. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-09 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181008194826.4201.17957@vcs0.savannah.gnu.org>
[not found] ` <20181008194827.A075520468@vcs0.savannah.gnu.org>
2018-10-08 20:08 ` [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754) Stefan Monnier
2018-10-09 18:17 ` Charles A. Roelli
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).