From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754) Date: Tue, 09 Oct 2018 20:17:04 +0200 Message-ID: References: <20181008194826.4201.17957@vcs0.savannah.gnu.org> <20181008194827.A075520468@vcs0.savannah.gnu.org> Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1539108674 26868 195.159.176.226 (9 Oct 2018 18:11:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2018 18:11:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 20:11:09 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9wTJ-0006lu-9M for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2018 20:11:05 +0200 Original-Received: from localhost ([::1]:53283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9wVP-0005hU-JQ for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2018 14:13:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9wVI-0005gF-LZ for emacs-devel@gnu.org; Tue, 09 Oct 2018 14:13:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9wVE-0007m8-73 for emacs-devel@gnu.org; Tue, 09 Oct 2018 14:13:08 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:38422) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g9wVD-0007lz-WB for emacs-devel@gnu.org; Tue, 09 Oct 2018 14:13:04 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 402F922891 for ; Tue, 9 Oct 2018 18:17:08 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:reply-to:subject:subject:in-reply-to:to:from:from :message-id:date:date; s=dkim; t=1539109026; x=1539973027; bh=XZ hfupzWGidoszBiHevwMvlTWzM+slujcRnuGIWbeHA=; b=c4KX7+hpSNMlAds3RO N4Ez2dmA0GZhKAlh/bkqnHSERI5n9G4IPJqAQogKdZdZLcQmPASnRjrkkedtjfgs jXkal/qXUDWmiV0JcX0aQPt+iECu720b2hDTYHZI5Nr+5nAE0JUs9jtAsjy4Xvsk Xr1/26QfxjpX0ZmZtAPlIvWfM= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5n0nEBEg6o7b for ; Tue, 9 Oct 2018 18:17:06 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 172F222879; Tue, 9 Oct 2018 18:17:06 +0000 (UTC) In-reply-to: (message from Stefan Monnier on Mon, 08 Oct 2018 16:08:49 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 37.35.109.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230293 Archived-At: > From: Stefan Monnier > Date: Mon, 08 Oct 2018 16:08:49 -0400 > > > +;;;###autoload > > +(defcustom vc-retrieve-tag-hook nil > > Why autoload this? Autoloading variables is usually a bad idea, so > unless there's a very good reason for it, we should remove this > autoload cookie. Ah, I see this is explained in the Elisp manual, "When to Autoload". I will remove the autoload, thanks.