From: charles@aurox.ch (Charles A. Roelli)
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754)
Date: Tue, 09 Oct 2018 20:17:04 +0200 [thread overview]
Message-ID: <m2y3b7yogv.fsf@aurox.ch> (raw)
In-Reply-To: <jwv5zycurq9.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Mon, 08 Oct 2018 16:08:49 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 08 Oct 2018 16:08:49 -0400
>
> > +;;;###autoload
> > +(defcustom vc-retrieve-tag-hook nil
>
> Why autoload this? Autoloading variables is usually a bad idea, so
> unless there's a very good reason for it, we should remove this
> autoload cookie.
Ah, I see this is explained in the Elisp manual, "When to Autoload".
I will remove the autoload, thanks.
prev parent reply other threads:[~2018-10-09 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181008194826.4201.17957@vcs0.savannah.gnu.org>
[not found] ` <20181008194827.A075520468@vcs0.savannah.gnu.org>
2018-10-08 20:08 ` [Emacs-diffs] master 7637216: New hook 'vc-retrieve-tag-hook' (Bug#32754) Stefan Monnier
2018-10-09 18:17 ` Charles A. Roelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y3b7yogv.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).