From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: process-file instead of call-process in proced.el? Date: Fri, 25 Mar 2022 03:09:12 +0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9298"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: winkler@gnu.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 25 01:10:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXXXK-0002Bs-EQ for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Mar 2022 01:10:39 +0100 Original-Received: from localhost ([::1]:54626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXXXI-0007rY-Qh for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Mar 2022 20:10:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXXW6-0007Ci-5l for emacs-devel@gnu.org; Thu, 24 Mar 2022 20:09:22 -0400 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:36233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXXW4-0006Vd-98; Thu, 24 Mar 2022 20:09:21 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 16C673201DCC; Thu, 24 Mar 2022 20:09:17 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 24 Mar 2022 20:09:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; bh=h iXigRQhcPQIA5/5uZYb+TXhRY4rjnZNjIHT6S6RvVI=; b=LfqhYcCLRPSaXvvYD JKmStezfBT2NQs0AVKPp4RP5MKPJifOH370KnlclTTinN16FPxjlrGucQOkVRnQd qBKI+y8Uekn0aCwbUGjfGhu14dMlzCsAhMCB7iKrD6jVkm+Ob85NjNerGhf8X+Z4 NJK4Wggt/c8nAPGs/2lGie6awV0hHA1rPbtMhF/yy2XNVgQNgxDik08zvKJfhuFR u1xwcdkqc5YOEes9e6TW4DVrVT+SQAOmlxDba0zdnx/FiOReEPyIZmbE/A/560tL xt7R0zhJYslw4tn5oLToWHDJ6lI+I5IxfAFzeDCg4Ysrxd1sE650cIydQWkAI/bf BFTAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hiXigRQhcPQIA5/5uZYb+TXhRY4rjnZNjIHT6S6Rv VI=; b=DeWkE+zKpIAn/D+KdavRwX8c/++IP1725P3eWpNhtp2SPwKo+6Rve9+Ki M2LaO15zhM0zueCf1Nj5euq0BjX+YxRjtNr0IPgpWwkW0QQUUmt8kmN+9fIBnk4Z fjy3aTPTOjnVKANWtAy/82mVD0NcAr04131Ijg59ZuJsk0cr+0DUHvMyJq+uY3eY SgQaU6I1t3ZJ0tI4A853GM84oZ907SwqZ668w5/w3xG7l5BiLGAQMh2mebH+ofsl fq47TjsmnMmX5DWlYbLOxq/xfq3lVjT84FCTkuoYgpAEs7UExu98v6KyW6orvOqu SJEnMAEzNzRwVkHyplDWIs9SEoShA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehtddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufgffkfggtgesthdtredttd ertdenucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghs thhmrghilhdrfhhmqeenucggtffrrghtthgvrhhnpeetkefggfejudejkeevheduteffud ffjeeutdevveefueevgfeiieeuueelkeduudenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehfghhunhgsihhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Mar 2022 20:09:15 -0400 (EDT) Received-SPF: pass client-ip=64.147.123.24; envelope-from=fgunbin@fastmail.fm; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287426 Archived-At: There's this TODO in proced.el: --8<---------------cut here---------------start------------->8--- ;; - Allow "sudo kill PID", "sudo renice PID" --8<---------------cut here---------------end--------------->8--- WDYT, can we just use process-file instead of call-process? Then, if proced is opened from a /sudo:: (or su) buffer, and (setq proced-signal-function "kill") is set, proced-send-signal "just works" for processes owned by different user, with no special code in proced. The simple patch is below. Filipp. diff --git a/lisp/proced.el b/lisp/proced.el index c1d599afc4..7d324a37a3 100644 --- a/lisp/proced.el +++ b/lisp/proced.el @@ -1833,7 +1833,7 @@ proced-send-signal (dolist (process process-alist) (with-temp-buffer (condition-case nil - (unless (zerop (call-process + (unless (zerop (process-file proced-signal-function nil t nil signal (number-to-string (car process)))) (proced-log (current-buffer)) @@ -1875,7 +1875,7 @@ proced-renice (dolist (process process-alist) (with-temp-buffer (condition-case nil - (unless (zerop (call-process + (unless (zerop (process-file proced-renice-command nil t nil priority (number-to-string (car process)))) (proced-log (current-buffer))