From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Building the igc branch on MS-Windows Date: Sat, 27 Apr 2024 15:23:54 +0200 Message-ID: References: <86il063imh.fsf@gnu.org> <87cyqcfv6k.fsf@gmail.com> <86o79wzi31.fsf@gnu.org> <86mspgza23.fsf@gnu.org> <867cgkz7e2.fsf@gnu.org> <87r0esdv7o.fsf@gmail.com> <87le50dmec.fsf@gmail.com> <8734r7etu1.fsf@gmail.com> <86il03xrlz.fsf@gnu.org> <868r0zxpfr.fsf@gnu.org> <861q6rxnst.fsf@gnu.org> <86wmojuj0m.fsf@gnu.org> <86ttjnuhyr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, eller.helmut@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 27 15:24:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0i2b-00059f-G9 for ged-emacs-devel@m.gmane-mx.org; Sat, 27 Apr 2024 15:24:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0i27-000163-OR; Sat, 27 Apr 2024 09:24:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0i25-00015Z-MU for emacs-devel@gnu.org; Sat, 27 Apr 2024 09:24:01 -0400 Original-Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0i24-0008Sy-2y; Sat, 27 Apr 2024 09:24:01 -0400 Original-Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-571c22d9de4so4199874a12.3; Sat, 27 Apr 2024 06:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714224236; x=1714829036; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0cKIeuFe+7/04Z2G/V1JUvTb78JZumfV9Tne8Yjy/oE=; b=ETXg869lp47IXB+PB/5gL4ysGCptEs3DY9asB4ALYLQecp/Q8Em2OkjGRWUAnA8sgV hVlIkBNUPZFqYK4oQ1MrbOZmEpmJsPjFCoAKaaTHNE3GOE3D6JNGMYRxdBqGbmL1jLCW 0POEYqb6C2FtYQO+s0J/LF6PkpxRmhYd7lAA4BP5OVEsqboSAG6ZLfFuYHihMISjITDp whVHflrCOPnZ+AYicjnmyMj7qqzB7J3orDkHCtOKBvo5Fob804qrYKOczEbdeLyNIfr7 ZQISgxG2ocGuEBuRD4LsWnyyJmsKGr9ozpmGp/eXesr37keAGNeN3uU9DXYaGIXfOubv hwqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714224236; x=1714829036; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0cKIeuFe+7/04Z2G/V1JUvTb78JZumfV9Tne8Yjy/oE=; b=DffGVKYbthVapBbB/QjBSEE3yClXh2//Favyte8meBYo5CLYlCDYmmBn2aIgPZTz4T a1wedw8NTU6oRHaRr3x/JhenprljwWNfYuCa7o1BB/gaiuqSa6GNxU8uB4GByo+iphJw ei1TMhVOt44gUdL+OqZh4p/BT0iG4PGox4g1aYKBtbpHs/9b6t5pbGAT3NjWY1+i9l5Y 0ohz4+mTarOqaRgES0C9uMxAXvrgBHUePpl0iyxyG/2uS6CqzxZ5Y//s1x6hPH6euv+C Ejw2kZ7O4uO/n3iue5WokVLhGywlcGiNJTltou1u5IDdwe+M0GBLnF+1POoE4JksEIBI 5KbQ== X-Gm-Message-State: AOJu0YzsW7nIEHZhVENAhe9SUf+njU8oh5aTgMIFyauZLVU3DkAl2Ef1 EhVwCCv3M8nUqwMcASzL5nk6VKrbufhPURHQTFPTl7bS4h0fLLgL X-Google-Smtp-Source: AGHT+IGoQBticlX2Kg5PqUe71ex5cpy/7jz9MyoWgBUb9M/74a6xZoWcFTVMOboyL7QYsD9jYMsEAg== X-Received: by 2002:a17:906:2c12:b0:a58:8491:29af with SMTP id e18-20020a1709062c1200b00a58849129afmr3775959ejh.41.1714224236367; Sat, 27 Apr 2024 06:23:56 -0700 (PDT) Original-Received: from pro2.fritz.box (p4fe3ae42.dip0.t-ipconnect.de. [79.227.174.66]) by smtp.gmail.com with ESMTPSA id n4-20020a170906164400b00a55967a9038sm9243138ejd.95.2024.04.27.06.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 06:23:55 -0700 (PDT) In-Reply-To: <86ttjnuhyr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Apr 2024 15:07:40 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318199 Archived-At: Eli Zaretskii writes: > Looking at the related parts in igc.c, I'm confused by how we handle > frames, their face caches, and the faces themselves. We have: > > . fix_face > . fix_face_cache > . IGC_OBJ_FACE and IGC_OBJ_FACE_CACHE cases in dflt_scanx > . call to IGC_FIX12_RAW (ss, &f->face_cache) in fix_frame > . igc_make_face_cache (which seems to treat a face cache as a PVEC??) > > Can you explain what each one of these do (or is supposed to do) in > the context of this puzzle? I think this starts with struct face, and struct face_cache. Faces are malloc'd in the non-MPS case, and allocated from MPS in the MPS build (igc_make_face), so face is a non-Lisp, but MPS-managed, GC'd object. Hence the existence of fix_face. Reason for that change are the Lisp_Objects in struct face which need to be traced. Now that struct face is managed by MPS, we automatically land in face_cache which holds struct face, which must now be traced. And boom, face_cache lands in MPS and gets a fix_face_cache. I think that explains what you asked?