From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Sun, 30 Jun 2024 14:28:18 +0200 Message-ID: References: <87v81u85hv.fsf@localhost> <87frsx81m2.fsf@localhost> <87cyo180y2.fsf@localhost> <874j9d7zqe.fsf@localhost> <87sewvg6lw.fsf@localhost> <87sewuk4l6.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3383"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii , eller.helmut@gmail.com To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 30 14:28:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNtfl-0000eL-Nr for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Jun 2024 14:28:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNtfN-0002KX-KL; Sun, 30 Jun 2024 08:28:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNtfM-0002KJ-2N for emacs-devel@gnu.org; Sun, 30 Jun 2024 08:28:24 -0400 Original-Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNtfK-0005Kb-Ar; Sun, 30 Jun 2024 08:28:23 -0400 Original-Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4256f102e89so14164745e9.0; Sun, 30 Jun 2024 05:28:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719750500; x=1720355300; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sd6OCMwtBNj9U+j5k6x5ClvyTjIYXSRy08AeViHXRLQ=; b=L8KBoYa+k1ehd02+13jlmqm4PLL6fswLzDrzLZNgXZ6iqDXnHKRM3cx4j61+APSDFM xmvuvA9jg+MWh4vzPi48WusHqIL1NnEasb+C30Ut1mncZc3uSgdgTOQr+bnwXHKFI+Zr hQmbLkcyxumsjn7jZH3UAHosvEQGTDrjQZF/rg/DDCTFV7Hey6Ylpe4O9dO9S/agaYLk eUeXzLHzdyO6UHDbatAH9jf0yYS5IhRXgBmZvWWmSgiDZ9Ap/+Iv8ngaCe0rDmb+xWPo JY4GTu1J0JVBwQAL4kXrEBTN8wIqmDO0AcD4W251+sKROWqF3VE2Kcde5x1CemAXxvio y0AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719750500; x=1720355300; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sd6OCMwtBNj9U+j5k6x5ClvyTjIYXSRy08AeViHXRLQ=; b=w3U/GBA/WC9Jkrdtq/54nGlXUAQmS11rZvdnXyarZlZLWqVfR7/2Sp+AMQwkMntot4 ZkWwaB+cYS/sgfNvuMEKXbapP/Uw9KmDgF1tCICJGroySDpHRNmWlDs4JoHNRJP5+WVb LUn/DQf5DIxUbOKaNgXF+Xg/AGKLzeKrGyq/KM4D1sjmFyZ1pI9CE4qP8+FlFTyfPG1d SFSuR8qy8cTYsrsjWIBAMSEgUdywX5fk+lCKOB001TgEoVXmibOHpQ/3uta7yun2QSwR X0EJNaj6kR3p/6XlyGhbeTIEMmgsNAR8l7uuqBD/BqWuCogW1NYMiZYtZNCoq9BemcM2 ugoQ== X-Forwarded-Encrypted: i=1; AJvYcCUCq5IK9xP0VtZODeGA1Z0eJZ2ez+DbWAa/JJA2kMiqAUOVE9ahQ+VtV3OCblTo6OyI6FjZIyQxX3/HHPcFiSwYfbxMGQ+HQiHJYK/RX60e3uk= X-Gm-Message-State: AOJu0YzVKdj0WuqCvGqNWqbSab5qwT498h3t/+Hr4AaINVKrqCrqOe4v 86kItksumOpdTuDlcbcCPG2Z0N137iByoLvJ7qS3lnqLupJqNlgE X-Google-Smtp-Source: AGHT+IEKZO/8SM6SB+zeA5j5HtwJFPS7iUp6yERstiTk/JFpB3xxZa/SpE4z/hUD6oj2lmpt+iAolQ== X-Received: by 2002:a05:600c:2150:b0:424:a4ab:444f with SMTP id 5b1f17b1804b1-4257a02f1bdmr18594825e9.33.1719750499587; Sun, 30 Jun 2024 05:28:19 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36a45.dip0.t-ipconnect.de. [217.227.106.69]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4257f44c730sm16290515e9.39.2024.06.30.05.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 05:28:19 -0700 (PDT) In-Reply-To: <87sewuk4l6.fsf@localhost> (Ihor Radchenko's message of "Sun, 30 Jun 2024 12:17:09 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=gerd.moellmann@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320959 Archived-At: Ihor Radchenko writes: > Gerd M=C3=B6llmann writes: > >> Gerd M=C3=B6llmann writes: >> >>> I think I have an idea: What if igc_add_marker records in Lisp_Marker at >>> which index in the weak vector it stored the marker? That would make >>> igc_remove_marker O(1). >> >> Pushed that to scratch/igc. >> >> Ihor, could please measure again? > > As expected, igc_remove_marker disappeared. igc_add_marker is still there. > > 33.12% emacs emacs = [.] igc_add_marker Thanks, Ihor, that looks promising. I've now also pushed a quick and dirty add_marker in O(1), that's why I reverted. to get that on top. Works for me... A comparison of how it feels compared to master would also be interesting.