From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: scratch/igc fe90d556834: Make glyphs ambiguous roots
Date: Mon, 29 Jul 2024 16:12:45 +0200 [thread overview]
Message-ID: <m2y15knv6q.fsf@pro2.fritz.box> (raw)
In-Reply-To: <87r0bcfgb1.fsf@gmail.com> (Helmut Eller's message of "Mon, 29 Jul 2024 16:01:22 +0200")
Helmut Eller <eller.helmut@gmail.com> writes:
> On Mon, Jul 29 2024, Gerd Möllmann wrote:
>
>>>> While the doc doesn't guarantee that all other (registered) threads are
>>>> suspended, it's hard to imagine what else MPS could do to stop other
>>>> threads from messing up the object. (MPS must remove hardware barriers,
>>>> so that's not an option.)
>>>
>>> Good point, indeed.
>>>
>>> I've reverted that change. Thanks for checking!
>>
>> By the same argument, I think we could simplify face_cache and
>> image_cache which both use IGC_OBJ_PTR_VEC at the moment.
>> IGC_OBJ_PTR_VEC could then go completely.
>
> You mean, you would use the regular xmalloc instead of igc_make_ptr_vec
> to allocate those vectors and trace the vectors in fix_face_cache. Hm,
> yes that's indeed a similar situation. As long as those caches aren't
> roots, I don't see a problem.
Yes, axactly. The bucket vectors and face_cache::faces_by_id and
image_cache::images could be xmalloc'd like in the non-MPS case,
and fix_face_cache and fix_image_cache could iterator over them and so
on.
> I guess this would make the MPS and non-MPS code more alike. We'd lose
> some details for igc-info, though that's a minor issue.
Yes, and things gets a bit simpler, which I'm personally a big fan of.
I'll put that on my todo list.
Thanks!
prev parent reply other threads:[~2024-07-29 14:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172218853212.17772.9043342656088870281@vcs2.savannah.gnu.org>
[not found] ` <20240728174212.BDB66C41F13@vcs2.savannah.gnu.org>
2024-07-29 6:21 ` scratch/igc fe90d556834: Make glyphs ambiguous roots Helmut Eller
2024-07-29 7:21 ` Gerd Möllmann
2024-07-29 9:21 ` Helmut Eller
2024-07-29 10:19 ` Gerd Möllmann
2024-07-29 13:12 ` Gerd Möllmann
2024-07-29 14:01 ` Helmut Eller
2024-07-29 14:12 ` Gerd Möllmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y15knv6q.fsf@pro2.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).