From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/no-purespace to remove unexec and purespace Date: Tue, 17 Dec 2024 15:20:50 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11141"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Pip Cet , Stefan Monnier To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 17 15:21:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNYSI-0002jt-8b for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Dec 2024 15:21:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNYRV-0004NL-96; Tue, 17 Dec 2024 09:20:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNYRT-0004Mt-D4 for emacs-devel@gnu.org; Tue, 17 Dec 2024 09:20:55 -0500 Original-Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNYRR-0003gf-Rx for emacs-devel@gnu.org; Tue, 17 Dec 2024 09:20:55 -0500 Original-Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5cecbddb574so9026307a12.1 for ; Tue, 17 Dec 2024 06:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734445252; x=1735050052; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qPJAa6jSGt6Ud7hSgBPzTj0KSGgRCFIIrwIDim47BxA=; b=NdiBgkFipcY41cAH7WvKe8nopGAmY4qJ3NNycPdxXdOL/C7irpZK/f75+nSEAOmhDG WGDGjJNnwY/DOK0PLrd1sw5v1yYsngNwB6qwNgtlQD9uU9KmUo045rWf6DZsnWpvMi9D 7A5KBsYkUQ9bQzaXYnsSx/D6VGUUD/xfzSo2e01PZ07oxaXNi1nIvGsslotg1jeAIdf3 +E8oQijLHGSNuFdwL5+2n7nVvuznwbm2t37olDZKRXNxNfEHUW6/0Mog8JiBSpSGfMcC +r9wYqAPS6c4XQr9mYfTsGcFeDAeyvzP4rY/S3uIPJ6SRhRwvNrNRoCh/TnkJOebHy/z LDyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734445252; x=1735050052; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qPJAa6jSGt6Ud7hSgBPzTj0KSGgRCFIIrwIDim47BxA=; b=oIYXwgtUYGD8lu7YCfwkZ8r7/IjtSmf9gx+9XxJ+ghilg4VV/QWmVpikzpf0K8XMH0 17d7yYv6xgOiWEpD/CcO0TleV/OtH4LPsSQgs2x2s8NaBOf+damcYZfm2XGfwTBGwZCC /Ravor2fcXFQbr7nbpewzgx7+sQscdzSs66aOPFfpK9u5qPobd3y73PZtGS9QvxYrTXh gtm37kX03iXfaArjzgyzPX+pmNv9lIhqOgFkXsyTfqpSxDPv/Icl5c1KNbym8vMhQXm+ M/2+t3hCrwb5/mTNxd3HjzlDlh3bSun7SyXujH+hmwCazQk2Tqyere5Ta+Lk0TxsJpVD 9z4w== X-Gm-Message-State: AOJu0YxmI3kbQOGczwKOC94mc2iMg9vhcbGrpG2t3Z1LHeijM2VGsf67 8zh24cK0VAaskR4Mk3ib5z622l2ExjAoqLME5yfsk1DOY1xi+uEA X-Gm-Gg: ASbGncslDFo7BDBsyvTLNOysP19YikQbe5sQ6jHt5Q4BtX2gz4AdTtrgXBqSF9OtZ1N B9Mp0GGeAXLSKqH21NzVjjGHTDlhdYZaOctysPXktEsrhBln8esKwkQTLmq50BpjFApYBhD4YHj dtfxgU7zTMjOCYlVLtfRKYP6J2pUKqWRl9SfbYgci8d30DP5DSdMA2ok7Hd3p9wsBWIFGjd2muc 4kSVYrGGdnXm/3e6vpf3NZLY7vjPT7zlkBun3MXCGPTR0Y3x2ks3UouyBHVN6v2fvLp4bKWp4/I HUtYUdZvHubPIJoydwOEmh5s5EFQ3upxMlMRxh6g7wIWcTW7ne5f9ZAWHqamnXg= X-Google-Smtp-Source: AGHT+IGkFOHBf4rFZyBcVYsTsLL2debBjMENL89yrJ6T3gjQaGOuK6U/bSYtuWHzuNK/9at2mXBX5g== X-Received: by 2002:a05:6402:1e89:b0:5d4:4143:c07a with SMTP id 4fb4d7f45d1cf-5d63c2f8decmr11444956a12.1.1734445251939; Tue, 17 Dec 2024 06:20:51 -0800 (PST) Original-Received: from pro2 (p200300e0b70d29009cfd954400434498.dip0.t-ipconnect.de. [2003:e0:b70d:2900:9cfd:9544:43:4498]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d652ad1717sm4389360a12.21.2024.12.17.06.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 06:20:51 -0800 (PST) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llmann=22'?= =?utf-8?Q?s?= message of "Tue, 17 Dec 2024 14:12:11 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326597 Archived-At: Gerd M=C3=B6llmann writes: > Stefan Kangas writes: > >> In August, we decided to remove the unexec build along with purespace. >> The scratch/no-purespace branch removes both, and has been rebased on >> top of a recent master. >> >> We, the maintainers, believe that the scratch/no-purespace branch is >> now ready to merge, and would appreciate any final feedback, testing, >> and code reviews. Specifically, the branch has been primarily tested >> on GNU/Linux and macOS, so testing on other systems would be greatly >> appreciated. >> >> Unless we uncover any serious blocking issues, or significant or >> unexpected objections from the community, we plan to merge the >> branch on February 1, 2025. >> >> During our last discussion, we identified some issues with using >> pdumper on some legacy proprietary systems: MS-DOS, Windows 98, and >> Solaris 10 Zone. As we have explained previously, patches are welcome >> for these issues, but we do not currently consider them as blockers >> for this merge. >> >> Thanks! >> >> Stefan Kangas, on behalf of the Emacs maintainers > > Building on macOS with --enable-checking=3Dall --with-native-compilation > gives assertion violations. It builds without the --enable-checking. > > gmake -C ../lisp compile-first EMACS=3D"../src/bootstrap-emacs" > ELC+ELN emacs-lisp/comp-common.elc > ELC+ELN emacs-lisp/comp-run.elc > ELC+ELN emacs-lisp/radix-tree.elc > ELC+ELN emacs-lisp/loaddefs-gen.elc > ELC+ELN emacs-lisp/macroexp.elc > ELC+ELN emacs-lisp/cconv.elc > ELC+ELN emacs-lisp/comp-cstr.elc > ELC+ELN emacs-lisp/bytecomp.elc > ELC+ELN emacs-lisp/byte-opt.elc > ELC+ELN emacs-lisp/comp.elc > gmake -C ../lisp autoloads EMACS=3D"../src/bootstrap-emacs" > ELC+ELN ../lisp/cus-face.elc > > comp.c:5322: Emacs fatal error: assertion failed: check_comp_unit_relocs = (comp_u) > gmake[3]: *** [Makefile:285: ../lisp/cus-face.elc] Abort trap: 6 > ELC+ELN international/titdic-cnv.elc > > comp.c:5322: Emacs fatal error: assertion failed: check_comp_unit_relocs = (comp_u) > Fatal error 6: Aborted > gmake[3]: *** [Makefile:330: international/titdic-cnv.elc] Abort trap: 6 > gmake[2]: *** [Makefile:901: ../lisp/cus-face.elc] Error 2 > gmake[2]: *** Waiting for unfinished jobs.... > gmake[2]: *** [Makefile:961: ../lisp/loaddefs.el] Error 2 > ELC+ELN ../lisp/abbrev.elc > > comp.c:5322: Emacs fatal error: assertion failed: check_comp_unit_relocs = (comp_u) > gmake[3]: *** [Makefile:285: ../lisp/abbrev.elc] Abort trap: 6 > ELC+ELN ../lisp/button.elc I think check_comp_unit_relocs should be removed in the branch. What's left of it the branch, checks in master if everything has been put in purespace which should be there. IIUC correctly, of course.