unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: John Wiegley <jwiegley@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: "Artur Malabarba" <arturmalabarba@gmail.com>,
	"Zack Piper" <zack@apertron.net>,
	"Aurélien Aptel" <aurelien.aptel@gmail.com>,
	"Emacs developers" <emacs-devel@gnu.org>
Subject: Re: [PATCH] Fix (letrec ((ignore)))
Date: Sat, 12 Dec 2015 15:10:05 -0800	[thread overview]
Message-ID: <m2wpsjqn5e.fsf@newartisans.com> (raw)
In-Reply-To: <CAFyQvY3PN5PNK4vobaLKT-Khk4qjtGxqafqzkYmwj0QahKuLpw@mail.gmail.com> (Kaushal Modi's message of "Fri, 11 Dec 2015 15:08:18 -0500")

[-- Attachment #1: Type: text/plain, Size: 777 bytes --]

>>>>> Kaushal Modi <kaushal.modi@gmail.com> writes:

> Would it be better instead to fix the org-mode files for consistency?
> - Replace all instances of
> (letrec ((SOMEVAR)) ..)
> with
> (letrec ((SOMEVAR nil)) ..)

(letrec ((SOMEVAR))) should be an error, since the value is missing. If one
wishes to declare SOMEVAR with a nil value, the correct forms are:

    (letrec ((SOMEVAR nil)))
    (letrec (SOMEVAR))

> Question to emacs-devel: What would be the right approach?

We should give `letrec' the same treatment we've given to `setq' and `setf',
and then Org and other users should be corrected.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

  reply	other threads:[~2015-12-12 23:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 16:11 [PATCH] Fix (letrec ((ignore))) Zack Piper
2015-12-11 20:08 ` Kaushal Modi
2015-12-12 23:10   ` John Wiegley [this message]
2015-12-13  4:08     ` Kyle Meyer
2015-12-13 12:13     ` Alan Mackenzie
2015-12-13 17:41       ` Drew Adams
2015-12-13 22:19         ` Kaushal Modi
2015-12-13 23:05           ` Drew Adams
2015-12-14 18:23       ` John Wiegley
2015-12-14 20:24         ` Alan Mackenzie
2015-12-14 20:25           ` John Wiegley
2015-12-14 20:47             ` David Kastrup
2015-12-14 21:55               ` John Wiegley
2015-12-15 14:14               ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wpsjqn5e.fsf@newartisans.com \
    --to=jwiegley@gmail.com \
    --cc=arturmalabarba@gmail.com \
    --cc=aurelien.aptel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=zack@apertron.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).