From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Small frameset bug Date: Mon, 03 Feb 2020 16:13:00 +0100 Message-ID: References: <3B26F6D5-7EE3-4523-A7D7-685D869C3C8E@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="122962"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lekktu@gmail.com, emacs-devel@gnu.org To: JD Smith Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 03 16:13:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iydQ8-000Vq8-58 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Feb 2020 16:13:52 +0100 Original-Received: from localhost ([::1]:42980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iydQ7-0008GS-7W for ged-emacs-devel@m.gmane-mx.org; Mon, 03 Feb 2020 10:13:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53008) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iydPV-0007pE-A0 for emacs-devel@gnu.org; Mon, 03 Feb 2020 10:13:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iydPT-00016I-GE for emacs-devel@gnu.org; Mon, 03 Feb 2020 10:13:12 -0500 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:38026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iydPS-00010t-55 for emacs-devel@gnu.org; Mon, 03 Feb 2020 10:13:10 -0500 Original-Received: by mail-wm1-x32e.google.com with SMTP id a9so17584996wmj.3 for ; Mon, 03 Feb 2020 07:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=qoTILj836ztwVmf3mIMYl+YnbkZ2CYOGMSeAmyINrNk=; b=OYdNX8iaeY59SsFHb2DxToBgDf0i6UwoiKDg36mlHHINcFEEIgbQYRzPdctUAtPrbK FPARAkkpGeBjo17w9mhJ1j4U+2usMvk67QZE9JF1ZtaM7Sj1ttGescvrBq+cSyj4/uAc 7C+q4CveNUmdRmUcM2r7w/SB8hHBoL28Id+Wrh+9M/AqtYzd4itCfobvsnbiIUV6yzPL dyJGcAz/IOwMCbLAvGdAV6tpN9Flswvf3Yg7a9yXKyoFGBYU7ifaI+Xe4gC0yj1OKXYH Xyn2Gvvt5RiDRDPUUyF91IaiynX28lmqvGM3zbKYtIekyQX/2Y92djxBwr77eE2rxnuY uJlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=qoTILj836ztwVmf3mIMYl+YnbkZ2CYOGMSeAmyINrNk=; b=gUtHNKWblWZy0sBy7ZesCg9dx56beti+vlgefWmy/A6UpXQYBF7h3mCnZWMe62hkVL hvER+h8rNvAvKgcKev1IUzYNDDdLKv4KjzZBMHhsYu8rvt3sQBc88Kt2NVebPBBOkk4K hzoYF1l4aVMsYdHh6mic+/sbOTGwpUm7al+UJr1HiqdM+QLzuGhmr3IAwq86zSH+hnsg tdkfyNUF7wY/fDFa26rg36I5JCJqXbtVWSCrW7aunyIl2pyZQo0VsDE17DmHGDwW1hb5 KmUp9K7AwQzFNf0/SjhNcubC/GxN9aDj+TJVYVxR4p+gQxxzFqUkBvLHXCijMA7CFpRf m1RA== X-Gm-Message-State: APjAAAWGGL8n/MMQhdRNr3Wfy4/6mcCZVwZCQ+2jA22E7AwUL42PlrXt 5Ol4fbEaeAI+kgYJfLD+ZiQ= X-Google-Smtp-Source: APXvYqzwCW6ig7ch84cEHjN7z3I9G/u99PesyJMzbnyQTZ0FQtkERnQ6XLoZh80ML/8p3wrT1AAMyA== X-Received: by 2002:a1c:b486:: with SMTP id d128mr30151601wmf.69.1580742784560; Mon, 03 Feb 2020 07:13:04 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:3d4d:125a:4f4d:e0]) by smtp.gmail.com with ESMTPSA id t81sm23661070wmg.6.2020.02.03.07.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 07:13:04 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <3B26F6D5-7EE3-4523-A7D7-685D869C3C8E@gmail.com> (JD Smith's message of "Mon, 3 Feb 2020 09:55:48 -0500") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244831 Archived-At: >>>>> On Mon, 3 Feb 2020 09:55:48 -0500, JD Smith said: JD> In `frameset--minibufferless-last-p`, the destructuring statements: JD> (pcase-let ((`(,hasmini1 ,id-def1) (assq 'frameset--mini (car state= 1))) JD> (`(,hasmini2 ,id-def2) (assq 'frameset--mini (car state2)))) JD> do not function as intended. Since the `assq` always produces =E2= =80=98frameset=E2=80=94mini` as its car, hasmini1/2 are always set to this = symbol. The subsequent `cond` still works as intended to sort minibufferles= s frames last: JD> (cond ((eq id-def1 t) t) JD> ((eq id-def2 t) nil) JD> ((not (eq hasmini1 hasmini2)) (eq hasmini1 t)) JD> ((eq hasmini1 nil) (or id-def1 id-def2)) JD> (t t)))) JD> but the 3rd and 4th conditions are never met. This may cause confu= sion for anyone trying to use the =E2=80=98frameset=E2=80=94mini frame para= meter. I guess you=CA=BCre looking in emacs-26? In emacs-27 'cdr' is applied to the 'assq' result. Robert