From: Robert Pluim <rpluim@gmail.com>
To: JD Smith <jdtsmith@gmail.com>
Cc: lekktu@gmail.com, emacs-devel@gnu.org
Subject: Re: Small frameset bug
Date: Mon, 03 Feb 2020 16:13:00 +0100 [thread overview]
Message-ID: <m2wo93ln5v.fsf@gmail.com> (raw)
In-Reply-To: <3B26F6D5-7EE3-4523-A7D7-685D869C3C8E@gmail.com> (JD Smith's message of "Mon, 3 Feb 2020 09:55:48 -0500")
>>>>> On Mon, 3 Feb 2020 09:55:48 -0500, JD Smith <jdtsmith@gmail.com> said:
JD> In `frameset--minibufferless-last-p`, the destructuring statements:
JD> (pcase-let ((`(,hasmini1 ,id-def1) (assq 'frameset--mini (car state1)))
JD> (`(,hasmini2 ,id-def2) (assq 'frameset--mini (car state2))))
JD> do not function as intended. Since the `assq` always produces ‘frameset—mini` as its car, hasmini1/2 are always set to this symbol. The subsequent `cond` still works as intended to sort minibufferless frames last:
JD> (cond ((eq id-def1 t) t)
JD> ((eq id-def2 t) nil)
JD> ((not (eq hasmini1 hasmini2)) (eq hasmini1 t))
JD> ((eq hasmini1 nil) (or id-def1 id-def2))
JD> (t t))))
JD> but the 3rd and 4th conditions are never met. This may cause confusion for anyone trying to use the ‘frameset—mini frame parameter.
I guess youʼre looking in emacs-26? In emacs-27 'cdr' is applied to
the 'assq' result.
Robert
next prev parent reply other threads:[~2020-02-03 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 14:55 Small frameset bug JD Smith
2020-02-03 15:13 ` Robert Pluim [this message]
2020-02-03 15:21 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wo93ln5v.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jdtsmith@gmail.com \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).