From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS codegen Date: Sat, 15 Jun 2024 14:33:05 +0200 Message-ID: References: <87wmmsg2e4.fsf@gmail.com> <878qz8ezn4.fsf@gmail.com> <8734pfgb51.fsf@gmail.com> <86ikybyd2h.fsf@gnu.org> <87v82bebc6.fsf@gmail.com> <86wmmrwf86.fsf@gnu.org> <86r0czwdmc.fsf@gnu.org> <87jzire36a.fsf@gmail.com> <86plsiwxag.fsf@gnu.org> <868qz6wsvq.fsf@gnu.org> <878qz6egtb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39862"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , acorallo@gnu.org, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 14:33:38 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sISbC-000AFa-8I for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 14:33:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sISao-0006D5-VU; Sat, 15 Jun 2024 08:33:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sISam-0006Cb-KU for emacs-devel@gnu.org; Sat, 15 Jun 2024 08:33:12 -0400 Original-Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sISaj-0001WS-BU; Sat, 15 Jun 2024 08:33:12 -0400 Original-Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-57c73a3b3d7so3409944a12.1; Sat, 15 Jun 2024 05:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718454787; x=1719059587; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dkjZUq+LMSP+2d8x2XwQQUAMt7Hz4FjInnr72B52Kyw=; b=KejEaDkYuHf37b3tC6hkJohFqRDkXrwXHHnKQf9aQi65z2mFF9Z5bu0hg3PH1h2Mtc dsA6PAX1ryh/GgVZZanBdb1wJI6k4O/ANTxeUuWjfvFMt8FjSMTiqX3AeZ0bxxdxxHde jycgEe/4Qku7Gune//E6nFe2ZgdioZrAmA+1aLlz8tjIPwIxWmGQ5yD4bT5E3kfyXo2M hdIh27wkOix26gY8QUn6v/bPt94IE7fqihwJA8cIq0uWe+oSSjNn3Qj+And2NEwzcTC7 ZlG5rmbz4rOBJ9mA7HM1lbpO5uTFtloX1dwB8KOBP0vdmepxjh1G+kc0hJeYh9QvVSFO LQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718454787; x=1719059587; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dkjZUq+LMSP+2d8x2XwQQUAMt7Hz4FjInnr72B52Kyw=; b=KFDkMOrjITjH2pXcHfeeTcRuzlHXWdHLVHIvoNGvhyINpFnVrWtGSAanp/qs0e5nLE P2UKXe6ubay+/HBVhkjtSx2KgTmjZEydt7TUrBeFawuXUFWT8lA70o+El9m/D9gHjYU7 YWdRTvezPXd5U/nTJFOZ6jcVOuyTXVRdQxAAhp99ah2GVaIrkuEroai4xWxO1Wo8CU1m Z/MjAdaEIiFMlMS3xUPJ0HOm7oy36aT7kudwFRL1GN2jasN7zMn+nUHuscsh1J63XXRA Q+FI0rdd3ZmTutQx772nEEVajKrxCtV+phlMLcJbjkiLAEnk11dUrti5oc/Yw2488a8v nIHA== X-Forwarded-Encrypted: i=1; AJvYcCWkozNhOIM1Eqf39F2OfUpv1B6Tu3ZkOi6onSnNlL5YnZoyij6pdCpzTe2wGqZbtejcFiBQfjMoDxtUVVwt5/2+saSzC9jxYH+7kkjDLdDvTIXjHVub X-Gm-Message-State: AOJu0YzNYiO8VtHQzE9GCM/YpiajEeQvNqEY/7ukcYU/T2a8XfDgW0R3 ErPj1e9PCb0fgm1etBNEozSgKu8UoWKytEu4cfBsRIIOgL9XL5AC4oAxgQ== X-Google-Smtp-Source: AGHT+IEHOw5uV6F7q3FkFpJyNstvEGQaACWm9QXOnnIDiK8JcsOKxi9HuEgQFyED9ugimNdFiXnH+w== X-Received: by 2002:a50:ab58:0:b0:57c:7541:c6a9 with SMTP id 4fb4d7f45d1cf-57cbd67f3d9mr2951776a12.24.1718454786612; Sat, 15 Jun 2024 05:33:06 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36be1.dip0.t-ipconnect.de. [217.227.107.225]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb7439606sm3619212a12.90.2024.06.15.05.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 05:33:06 -0700 (PDT) In-Reply-To: ("Gerd =?utf-8?Q?M=C3=B6llman?= =?utf-8?Q?n=22's?= message of "Sat, 15 Jun 2024 10:56:33 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320130 Archived-At: Gerd M=C3=B6llmann writes: > Helmut Eller writes: > >> On Sat, Jun 15 2024, Gerd M=C3=B6llmann wrote: >> >>> I can't munmap because that >>> would write back the changes done by the reloc phase back to the .pdmp >>> file. >> >> I think that's a misunderstanding. dump_map_file_posix sets MAP_PRIVATE >> for DUMP_MEMORY_ACCESS_READWRITE. So whatever changes the reloc phase >> makes, they are written to copy-on-write pages and never to disk. > > Hm, I can try that a bit later. So, the theory would be that mprotect > PROT_NONE does not work somehow on madvice'd not needed memory?=20=20 Indeed, after this change modified src/pdumper.c @@ -4931,9 +4931,10 @@ dump_discard_mem (void *mem, size_t size) (void) posix_madvise (mem, size, POSIX_MADV_DONTNEED); # elif defined HAVE_MADVISE (void) madvise (mem, size, MADV_DONTNEED); -#endif +# endif /* Release the commit charge for the mapping. */ - (void) mprotect (mem, size, PROT_NONE); + int rc =3D mprotect (mem, size, PROT_NONE); + eassert (rc =3D=3D 0); #endif } I get pdumper.c:4937: Emacs fatal error: assertion failed: rc =3D=3D 0 gmake[3]: *** [Makefile:335: emacs-lisp/byte-opt.elc] Abort trap: 6 gmake[3]: *** Waiting for unfinished jobs.... which is soothing. I'm reluctant to invest more time though because this all si obsolete with your change.