unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Emacs Devel <emacs-devel@gnu.org>
Cc: martin rudalics <rudalics@gmx.at>
Subject: Question about dubious code for terminal frames
Date: Mon, 02 Sep 2024 11:04:02 +0200	[thread overview]
Message-ID: <m2wmju8m0t.fsf@pro2.fritz.box> (raw)

In 3 places, among them adjust_frame_size, which is why I CC'd
Martin, Emacs sets the values of FrameRows/FrameCols.

AFAIU, these two values give the physical size of a terminal (screen,
window), as returned from the co and li escape sequences on termcap
frames. And I can't find code that tries to change the physical size of
the terminal, if that would even make sense in the first place :-). So
this doesn't make any sense to me.

Alas, the code in question has been so heavily modified over the decades
that I can't find out where this code originates from. Maybe it's even
something that I missed to fix when introducing the new redisplay,
because in the old redisplay it might have mad>e sense for GUI frames.
Maybe, don't remember.

In any case, does someone have an idea what that code is for? If not,
I suggest to remove it (and maybe making them rvalues or const).



             reply	other threads:[~2024-09-02  9:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02  9:04 Gerd Möllmann [this message]
2024-09-02  9:10 ` Question about dubious code for terminal frames Andreas Schwab
2024-09-02  9:48   ` Gerd Möllmann
2024-09-02 10:23     ` Andreas Schwab
2024-09-02 10:46       ` Gerd Möllmann
2024-09-02 11:44 ` Eli Zaretskii
2024-09-02 12:59   ` Gerd Möllmann
2024-09-02 13:17     ` Eli Zaretskii
2024-09-02 14:11       ` Gerd Möllmann
2024-09-02 14:35         ` Eli Zaretskii
2024-09-02 14:54           ` Gerd Möllmann
2024-09-02 15:31             ` Eli Zaretskii
2024-09-02 15:46               ` Gerd Möllmann
2024-09-02 15:55                 ` Eli Zaretskii
2024-09-02 16:24                   ` Gerd Möllmann
2024-09-02 16:35                     ` Eli Zaretskii
2024-09-02 16:38                       ` Gerd Möllmann
2024-09-02 17:39                         ` Eli Zaretskii
2024-09-02 16:20               ` martin rudalics
2024-09-02 16:31                 ` Gerd Möllmann
2024-09-02 17:32                   ` martin rudalics
2024-09-02 18:02                     ` Gerd Möllmann
2024-09-02 18:26                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wmju8m0t.fsf@pro2.fritz.box \
    --to=gerd.moellmann@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).