From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filippo Argiolas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: eglot-inactive-regions Date: Fri, 06 Dec 2024 10:21:24 +0100 Message-ID: References: <874j3nrri7.fsf@posteo.net> <878qswlfty.fsf@posteo.net> <87ldwvjdzl.fsf@posteo.net> <878qsu3zln.fsf@posteo.net> <87jzcd2nkg.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26265"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=C3=B6llmann?= , Stefan Kangas , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 06 10:22:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJUXX-0006gE-V4 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Dec 2024 10:22:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJUWj-000794-BR; Fri, 06 Dec 2024 04:21:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJUWg-00078n-P1 for emacs-devel@gnu.org; Fri, 06 Dec 2024 04:21:30 -0500 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJUWe-0004rS-U1 for emacs-devel@gnu.org; Fri, 06 Dec 2024 04:21:30 -0500 Original-Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-434aafd68e9so12946515e9.0 for ; Fri, 06 Dec 2024 01:21:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733476887; x=1734081687; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1lEQA9GGupsR11WmrOwm06zx/G/nOP+TS8YWGeGKUGY=; b=FQ1EwaUfznSyTcYg/Srlychu27aaOHT58Y3PAw1lYSiG9dwYks/rQsLGbQJYEQ25Bm UICzE/6lm20Xmpm1AhQReEQ/RmfNcSZNV6/sm+Mggs/k62Yeuet5E8T4BZ6EkL35pP/s R0q5nwS+f0P3pep2mpI88oimWy8rnESkbBTZUiQnzg5SqdmD8Znv/oRAc7gYzEYqdTvs Zl/wV9MQS5Eqvs/WiH79Eak7034YW89jDtS91ylix15n3wrKHUNrfFnU5oIVx3dwjrct QWeNKRe96inURSym5x0wurWSJxSET3xH+51taq0KVXt09pgc5BSv9f2ntnUlSslaN9DE ui+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733476887; x=1734081687; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1lEQA9GGupsR11WmrOwm06zx/G/nOP+TS8YWGeGKUGY=; b=L736IGNfFVH2ixL8P64ZI3KbLuTexMm5yeotxaSeF3NEVt6Ci/+ocZbdCtC2CgwqhC rpHo2Ffd6KhQvVF7rh6S2+ES/zcOsi7ouTLyQ/MJzT6hEvPCnB1FZO2MPV81eoBzKPJr oot0SOEh1V3G5GbLyRaFDsng6Eqa+8RvaFgWE0WeFnJk+CTem9djFuG7dthHUnYja/IU 2dERH7VuHlSNZ3zHcXkNwYaEhLWDCXBjERa9bTWFWAg/MliV2d8K1nN3pqnIkHZA2qa1 GHT9cTVZHhGj+Q0OADjb4VLgRx9o1ErQw9nZSr9dUrDYTQj32vQQU1uEEmkAchY+7b14 +Nrw== X-Gm-Message-State: AOJu0YwqerXaIsBJse6zM6IERf+caXJUdTRAFvhtebbNYRAumwCh3jwX JnL6FyaiP4d/o9xV7StLma8bptnk6VtdSOIoI6mdbLUvLvfjaror X-Gm-Gg: ASbGncvotjB1dDv0KVjb3wHSQAORiKkHL/5KYDg5s+Je7X5LGA3RSa0mNJt3W8bw6Jm EqxzHQahhPhxkRMcMBtjy8+Pp3lVq6z1o9Bl821how9mc/YTcet6OkDwzQREb2vwNI4Z6heo53m J2ZfbmXgAV1TTbsklTQLseKMWI9jPDdEZcZwDv4UC0qpJjPONCs0kxWhwAIWzDvneGsjh8Kz/UY 0CcnCGi1GNsuUNtUBQ6Fmy210LtTgr0SGnECxSrtarrP4M3Ad7GEdFeVQ== X-Google-Smtp-Source: AGHT+IE1sabkMKy7T32hmSY5B4vH+0rI1s409pd0QgGvHJncgW+J8AcPXN6UOj8hBHksQYohFJAmIg== X-Received: by 2002:a5d:64e7:0:b0:385:e105:d884 with SMTP id ffacd0b85a97d-3862b3e60d9mr1397041f8f.46.1733476886858; Fri, 06 Dec 2024 01:21:26 -0800 (PST) Original-Received: from mba ([151.56.36.113]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3861ecf40a0sm4067692f8f.13.2024.12.06.01.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 01:21:26 -0800 (PST) In-Reply-To: <87jzcd2nkg.fsf@posteo.net> Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=filippo.argiolas@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326126 Archived-At: Philip Kaludercic writes: > Filippo Argiolas writes: > >> Philip Kaludercic writes: >> >>> Filippo Argiolas writes: >>> >>>> Philip Kaludercic writes: >>>> >>>>> Filippo Argiolas writes: >>>>> >>>>>> Filippo Argiolas writes: >>>>>> >>>>>>> Philip Kaludercic writes: >>>>>>> >>>>>>>> I would try something of the form like >>>>>>>> >>>>>>>> (if (fboundp 'new-function) >>>>>>>> (new-function ...) >>>>>>>> (old-function ...)) >>>>>>>> >>>>>>>> If on the other hand there has already been a new release of Eglot= with >>>>>>>> these commands, then just depend on that version and the issue wou= ld >>>>>>>> resolve itself. >>>>>>>> >>>>>>> >>>>>>> CC-ing Jo=C3=A3o. >>>>>>> >>>>>>> I pushed the suggested change but I still get the compile warnings = about >>>>>>> deprecated functions. I'd like to keep supporting emacs-29, should I >>>>>>> just disregard the warning? >>>>>>> >>>>>>> Sorry for the ignorance, how would the dependency on a specific egl= ot >>>>>>> version work now that it's in core? >>>>>>> Does it require the users to have additional repos enabled? >>>>>>> >>>>>>> Sounds strange to me that we have macros to deprecate functions but= no >>>>>>> mechanism to automatically switch to the new one if it's just a >>>>>>> rename. Am I missing something obvious? >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>>> Filippo >>>>>> >>>>>> How about something like: >>>>>> >>>>>> ;; fallback to deprecated eglot functions >>>>>> (when (version< emacs-version "30") >>>>>> (defalias 'eglot-uri-to-path 'eglot--uri-to-path) >>>>>> (defalias 'eglot-range-region 'eglot--range-region)) >>>>>> >>>>>> or even something similar with a check on eglot version? >>>>> >>>>> That can be dangerous if other packages do fboundp checks and infer t= oo >>>>> much from that. I would try to see if adding `declare-function's cou= ld >>>>> help suppress the warnings? >>>> >>>> Nope, the only solution working so far is to call the deprecated >>>> functions with `with-no-warnings'. >>>> >>>> Guess I'll go with this. I'd be fine with the warnings too if we didn't >>>> have the annoying habit of scaring the end users with them :-) >>> >>> I don't have your source code available right now, my last suggestion >>> would be to use `with-suppressed-warnings' where you can suppress >>> specific obsoletion warnings, but that requires Emacs 27.1 or newer. >>> >> >> Thanks this seems to do the trick! > > OK great, I'll add the package to NonGNU ELPA. Can you just add a > .elpaignore file that lists the "screenshot" directory to be excluded > from the tarball? > > PS. Using the command "oxipng -o max -Z" I could compress one of the > images by 49%. You might also consider creating a SVG screenshot. Great, thanks! Added screenshots to ignore, let me know if I also have to bump the release number. One of these days I wanted to update screenshots as they look ugly on lower res displays, will consider switching to SVG ones.