From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Status of MAC/W32/X consolidation -- first major patch committed. Date: 17 Mar 2003 08:56:08 +0000 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <5xadg38lnj.fsf@kfs2.cua.dk> <5xheaaq93k.fsf@kfs2.cua.dk> <5xbs0bq8en.fsf_-_@kfs2.cua.dk> <5x3clmrhgj.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1047891476 16927 80.91.224.249 (17 Mar 2003 08:57:56 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 17 Mar 2003 08:57:56 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 17 09:57:54 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18uqRO-0004Ot-00 for ; Mon, 17 Mar 2003 09:57:54 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18uqqy-0003tH-00 for ; Mon, 17 Mar 2003 10:24:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18uqRj-0001FJ-00 for emacs-devel@quimby.gnus.org; Mon, 17 Mar 2003 03:58:15 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18uqRK-00017N-00 for emacs-devel@gnu.org; Mon, 17 Mar 2003 03:57:50 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18uqQG-0000gf-00 for emacs-devel@gnu.org; Mon, 17 Mar 2003 03:56:46 -0500 Original-Received: from server0011.freedom2surf.net ([194.106.56.14] helo=server0027.freedom2surf.net) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18uqQ2-0000ZF-00 for emacs-devel@gnu.org; Mon, 17 Mar 2003 03:56:31 -0500 Original-Received: from nyaumo.jasonr.f2s.com ([195.137.103.251]) h2H8uWRT007089; Mon, 17 Mar 2003 08:56:32 GMT Original-Received: from nyaumo.jasonr.f2s.com (localhost [127.0.0.1]) by nyaumo.jasonr.f2s.com (Postfix) with ESMTP id E5AA84A941; Mon, 17 Mar 2003 08:56:08 +0000 (GMT) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: <5x3clmrhgj.fsf@kfs2.cua.dk> Original-Lines: 18 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12400 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12400 storm@cua.dk (Kim F. Storm) writes: > I swapped the names of "w32_get_glyph_overhangs" and > "x_get_glyph_overhangs" to make the X and W32 code less different... That could be dangerous. Usually if I changed the x_ prefix to w32_, I did so because the interface or effect of the function was different. In this case, the interface was as follows. static void w32_get_glyph_overhangs P_ ((HDC hdc, struct glyph *, struct frame *, int *, int *)); x_get_glyph_overhangs was probably a wrapper to present the same interface as the x equivalent, but less efficient due to needing to get the hdc on every call (it is called for every glyph displayed, so that makes a big difference).