unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* flyspell bug
@ 2005-10-02 17:08 Richard M. Stallman
  2005-10-02 20:10 ` Slawomir Nowaczyk
  0 siblings, 1 reply; 104+ messages in thread
From: Richard M. Stallman @ 2005-10-02 17:08 UTC (permalink / raw)


It seems to me that there is no reason for flyspell.el to check the
buffer-local specifications every time it checks or corrects a word;
doing this when the user enables Flyspell mode ought to be enough.

Which suggests making this change.  Does it fix the problem?


*** flyspell.el	20 Sep 2005 19:31:14 -0400	1.76
--- flyspell.el	02 Oct 2005 01:38:17 -0400	
***************
*** 981,987 ****
    (interactive (list ispell-following-word))
    (save-excursion
      ;; use the correct dictionary
!     (flyspell-accept-buffer-local-defs)
      (let* ((cursor-location (point))
  	  (flyspell-word (flyspell-get-word following))
  	  start end poss word)
--- 981,987 ----
    (interactive (list ispell-following-word))
    (save-excursion
      ;; use the correct dictionary
! ;;;    (flyspell-accept-buffer-local-defs)
      (let* ((cursor-location (point))
  	  (flyspell-word (flyspell-get-word following))
  	  start end poss word)
***************
*** 1715,1721 ****
    (let ((pos     (point))
  	(old-max (point-max)))
      ;; use the correct dictionary
!     (flyspell-accept-buffer-local-defs)
      (if (and (eq flyspell-auto-correct-pos pos)
  	     (consp flyspell-auto-correct-region))
  	;; we have already been using the function at the same location
--- 1715,1721 ----
    (let ((pos     (point))
  	(old-max (point-max)))
      ;; use the correct dictionary
! ;;;    (flyspell-accept-buffer-local-defs)
      (if (and (eq flyspell-auto-correct-pos pos)
  	     (consp flyspell-auto-correct-region))
  	;; we have already been using the function at the same location
***************
*** 1886,1892 ****
  The word checked is the word at the mouse position."
    (interactive "e")
    ;; use the correct dictionary
!   (flyspell-accept-buffer-local-defs)
    ;; retain cursor location (I don't know why but save-excursion here fails).
    (let ((save (point)))
      (mouse-set-point event)
--- 1886,1892 ----
  The word checked is the word at the mouse position."
    (interactive "e")
    ;; use the correct dictionary
! ;;;  (flyspell-accept-buffer-local-defs)
    ;; retain cursor location (I don't know why but save-excursion here fails).
    (let ((save (point)))
      (mouse-set-point event)

^ permalink raw reply	[flat|nested] 104+ messages in thread
[parent not found: <E1DR6lU-0005vs-O1@fencepost.gnu.org>]
* flyspell bug
@ 2005-04-25 11:30 Stephen Eglen
  2005-04-26  1:28 ` Peter Heslin
  0 siblings, 1 reply; 104+ messages in thread
From: Stephen Eglen @ 2005-04-25 11:30 UTC (permalink / raw)



In today's CVS emacs:
emacs -q
C-h N
M-x flyspell-buffer

I get:  Error: Can't check region

and *flyspell-region* contains:
Error: Could not open the file "list" for reading.


This is compatibility problem between ispell and aspell.
I have:

$ ispell -v
@(#) International Ispell Version 3.1.20 (but really Aspell 0.50.5)

Relevant settings:
ispell-really-aspell t
ispell-program-name "ispell"

The problem is that ispell doesn't allow the "list" command:

$ echo "hello hhh" | ispell list
Error: Could not open the file "list" for reading.

whereas all the followng forms work (flagging hhh as a typo):

$ echo "hello hhh" | ispell  -l
$ echo "hello hhh" | aspell list
$ echo "hello hhh" | aspell -l


So can I suggest we make the simple change within:
(defun flyspell-large-region (beg end)

from 

(if ispell-really-aspell "list" "-l") (line 1332)

to

"-l"

Or are thing likely to be more complex depending on ispell/aspell version?

Stephen

^ permalink raw reply	[flat|nested] 104+ messages in thread

end of thread, other threads:[~2005-11-24 14:53 UTC | newest]

Thread overview: 104+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-02 17:08 flyspell bug Richard M. Stallman
2005-10-02 20:10 ` Slawomir Nowaczyk
2005-10-02 21:45   ` Kim F. Storm
2005-10-02 23:28     ` Slawomir Nowaczyk
2005-10-03 15:34     ` Richard M. Stallman
2005-10-03 16:14       ` Kim F. Storm
2005-10-03 19:31         ` Richard M. Stallman
2005-10-04  8:58           ` Kim F. Storm
2005-10-05  3:32             ` Richard M. Stallman
2005-10-05  8:34               ` David Kastrup
2005-10-03 15:35     ` Richard M. Stallman
2005-10-05 10:41       ` Slawomir Nowaczyk
2005-10-05 13:16         ` Slawomir Nowaczyk
2005-10-10  4:15           ` Richard M. Stallman
2005-10-12  8:43             ` Slawomir Nowaczyk
2005-10-13  4:52               ` Richard M. Stallman
2005-10-13 10:40                 ` Slawomir Nowaczyk
2005-10-14  5:11                   ` Richard M. Stallman
2005-10-14 11:59                     ` Slawomir Nowaczyk
2005-10-23  4:42                       ` Richard M. Stallman
2005-10-23 11:50                         ` Piet van Oostrum
2005-10-24  1:00                           ` Richard M. Stallman
2005-10-24  7:16                             ` Piet van Oostrum
2005-10-24 13:39                               ` Piet van Oostrum
2005-10-24 14:49                                 ` Piet van Oostrum
2005-10-24 23:22                                 ` Slawomir Nowaczyk
2005-10-25 13:40                                 ` Agustin Martin
2005-10-25 15:59                                 ` Richard M. Stallman
2005-11-18 15:54                                 ` Agustin Martin
2005-11-19 23:26                                   ` Richard M. Stallman
2005-11-20 20:36                                     ` Agustin Martin
2005-11-21  8:10                                       ` Richard M. Stallman
2005-10-24 16:27                               ` Richard M. Stallman
2005-10-24 17:51                                 ` Piet van Oostrum
2005-10-24 23:22                                 ` Slawomir Nowaczyk
2005-10-26 16:46                                   ` Richard M. Stallman
2005-10-27 17:20                                     ` Slawomir Nowaczyk
2005-10-28 16:19                                       ` Richard M. Stallman
2005-10-28 13:32                                     ` Agustin Martin
2005-10-28 21:57                                       ` Piet van Oostrum
2005-10-29  0:18                                       ` Slawomir Nowaczyk
2005-10-29 20:33                                         ` Richard M. Stallman
2005-10-31 14:50                                           ` Slawomir Nowaczyk
2005-11-01 10:19                                             ` Piet van Oostrum
2005-11-02 10:18                                               ` Slawomir Nowaczyk
2005-11-02 21:30                                                 ` Piet van Oostrum
2005-11-03 14:35                                                   ` Slawomir Nowaczyk
2005-11-04  9:20                                                     ` Piet van Oostrum
2005-11-04 12:27                                                       ` Agustin Martin
2005-11-04 14:04                                                       ` Slawomir Nowaczyk
2005-11-04 17:41                                                         ` Agustin Martin
2005-11-05  1:37                                                       ` Richard M. Stallman
2005-11-02 10:27                                               ` Richard M. Stallman
2005-11-07 15:35                                             ` Richard M. Stallman
2005-11-07 15:51                                             ` Slawomir Nowaczyk
2005-11-16 15:22                                               ` Agustin Martin
2005-11-18 14:51                                                 ` Agustin Martin
2005-11-23 10:19                                                 ` flyspell bug [possible patch] Agustin Martin
2005-11-24  3:58                                                   ` Richard M. Stallman
2005-11-24 14:53                                                     ` Agustin Martin
2005-10-29  5:13                                       ` flyspell bug Richard M. Stallman
2005-10-29 10:12                                         ` Piet van Oostrum
2005-10-29 12:11                                           ` David Kastrup
2005-10-29 19:51                                             ` Piet van Oostrum
2005-10-29 20:34                                           ` Richard M. Stallman
2005-10-30 13:25                                             ` Piet van Oostrum
2005-10-31  1:14                                               ` Richard M. Stallman
2005-10-30  1:14                                         ` Agustin Martin
2005-10-30 12:23                                           ` Piet van Oostrum
2005-10-28 11:11                                 ` Agustin Martin
     [not found] <E1DR6lU-0005vs-O1@fencepost.gnu.org>
2005-05-07 16:06 ` [mange@freemail.hu: Re: flyspell bug] Eli Zaretskii
2005-05-10  0:06   ` flyspell bug Juri Linkov
2005-05-10  3:37     ` Eli Zaretskii
2005-05-10  5:04       ` Juri Linkov
2005-05-10 19:46         ` Eli Zaretskii
2005-05-11  8:23           ` Juri Linkov
2005-05-11 12:40             ` Eli Zaretskii
2005-05-12  5:29               ` Juri Linkov
2005-05-12  6:55                 ` Eli Zaretskii
2005-05-12  6:14               ` Juri Linkov
2005-05-12  9:09                 ` Eli Zaretskii
2005-05-12 17:13                   ` Ken Stevens
2005-05-13 16:09                     ` Richard Stallman
2005-05-13 20:09                       ` Ken Stevens
2005-05-14  4:07                         ` Richard Stallman
2005-05-13  1:34                 ` Richard Stallman
2005-05-12  8:30             ` Richard Stallman
2005-05-23 14:51               ` Kevin Atkinson
2005-05-25  1:18                 ` Richard Stallman
2005-05-25 15:50                   ` Kevin Atkinson
2005-05-26  6:00                     ` Richard Stallman
2005-05-25 16:48                   ` Juri Linkov
2005-05-25 18:11                     ` Kevin Atkinson
2005-05-26  6:00                     ` Richard Stallman
2005-05-11 16:29     ` Richard Stallman
2005-05-12  5:28       ` Juri Linkov
2005-05-13  1:34         ` Richard Stallman
  -- strict thread matches above, loose matches on Subject: below --
2005-04-25 11:30 Stephen Eglen
2005-04-26  1:28 ` Peter Heslin
2005-04-26  8:30   ` Stephen Eglen
2005-04-26 22:55     ` Richard Stallman
2005-04-27  9:13       ` Stephen Eglen
2005-04-27 14:04         ` Magnus Henoch
2005-04-27 16:01           ` Stephen Eglen
2005-05-10 10:40   ` Kai Großjohann

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).