From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: search-default-mode char-fold-to-regexp and Greek Extended block characters Date: Mon, 29 Jul 2019 10:32:58 +0200 Message-ID: References: <87blxj3u4e.fsf@mail.linkov.net> <87ef2f0xx3.fsf@tcd.ie> <834l3ium3f.fsf@gnu.org> <83wogduc41.fsf@gnu.org> <83h87cpzml.fsf@gnu.org> <87r26gv6k2.fsf@mail.linkov.net> <87blxj3u4e.fsf@mail.linkov.net> <87a7d2asu3.fsf@mail.linkov.net> <87v9vp23g0.fsf@mail.linkov.net> <878sskybpi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="152194"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 29 10:33:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hs162-000dPG-D1 for ged-emacs-devel@m.gmane.org; Mon, 29 Jul 2019 10:33:30 +0200 Original-Received: from localhost ([::1]:50454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs161-0003c9-Cn for ged-emacs-devel@m.gmane.org; Mon, 29 Jul 2019 04:33:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47792) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs15g-0003XO-6S for emacs-devel@gnu.org; Mon, 29 Jul 2019 04:33:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hs15f-0002kS-5U for emacs-devel@gnu.org; Mon, 29 Jul 2019 04:33:08 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:42809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hs15e-0002jo-RK for emacs-devel@gnu.org; Mon, 29 Jul 2019 04:33:07 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id x1so10904712wrr.9 for ; Mon, 29 Jul 2019 01:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=rTkWAPFKxyIRWZJ5oW4iIRZfAjbOdZuw2edHVfgmhu8=; b=POXgT8k/iVHnCoYvFLLWxVQ3OUH1eZGEMmdgXHNWKLmUl10yigHg6ABFKfkGVnVF87 toAxvHGWogSI2b8FdtGQBmfFzQc49Lp2KTA05LN4JQGSLcKcEWViNLj2YyjBpQzMY7sN 9T5BukVY2Kk3wgGUagLLhYIo1gyt9GF830cEQR5BEs/qm4oLqB6UEgVwe+86ptk/1Sy9 ZbXthPaqRxkn7l4iT0zHgUZZfr6twecpSwsIl+tywhXtuBLK6EkeiLCxO13JmttsvlAy pQFeUVVWIWifHSj12NCN1D4mEkTiipWKyAxhQAl7Hj3BzsqyEcRa/WSfBmnVEN99sJnl 9RZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=rTkWAPFKxyIRWZJ5oW4iIRZfAjbOdZuw2edHVfgmhu8=; b=I1cMRwNPovj8zJ0RNXKNsmazZ7z/FLmPnItsGLDvVvkP72jqllA76CwDaOHRBbzENU tJFZHuN1mcEXyi5/h7GPcuXat9qXhl6H0PBs30MSGPYiyVAdQvUo0VJxHHgCFUjxWQZV lH+G+P3BWEXs1pPlm917gCIcBCqpazEz/0+4C82su1rO1U9QGkUyqCfbHuywOr5xbA/n V+Q4RbtWIuvBWu+51+wditKu1WkFu7GeESPafXq4tFmdqZRr4aTHOkBD64JSkg/dE7Bm ZZuwOU+YX5dwiZP1Q1X9kc0G1LstV9Vf51HS6PHgIy/PbMOrmh98AxF60/HA7ETeYx/2 EFJg== X-Gm-Message-State: APjAAAWlSKaQP70vIPxEqC9p2QvRn73AIImqTA4tsSb8Nnr0s9llBSTX sMG3qpBRWIwoPB/zcANOwQ6lTl7y X-Google-Smtp-Source: APXvYqyUSygeBE/pQewlj45c3AtVOGQOr1WvpUqHMCKWmNyq3y8zcA7DGlCuGSEC60iKHoVe5A9MNw== X-Received: by 2002:a5d:6190:: with SMTP id j16mr25400468wru.49.1564389185060; Mon, 29 Jul 2019 01:33:05 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id t15sm52873127wrx.84.2019.07.29.01.32.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 01:32:59 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <878sskybpi.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 26 Jul 2019 21:38:30 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238988 Archived-At: >>>>> On Fri, 26 Jul 2019 21:38:30 +0300, Juri Linkov sai= d: Juri> If there are many such cases, then better to handle them automati= cally indeed Juri> (if this doesn't cause slowdown too much) instead of adding them = one by one Juri> to the default values. Does this handle =C3=9F as well? >>=20 >> There are 74, and I don=CA=BCt want to maintain such a list by hand = :-). Juri> Yes, 74 is too tedious to maintain by hand, so better to install = your Juri> previous patch (if it doesn't have the problem mentioned below) s= ince The only difference between v2 and v1 of the patch is that v2 handles =C3=9F, so v1 is probably better. Juri> there are only 3 such complex characters (handled by your newer p= atch) Juri> that is easy to add by hand: Juri> '((?=C3=9F "ss") Juri> (?=E1=BF=93 "=CE=B9=CC=88=CC=81") Juri> (?=E1=BF=A3 "=CF=85=CC=88=CC=81")) I don=CA=BCt understand this comment. With v1 of the patch, =C3=9F is the o= nly one that would need to be added by hand to char-fold--default-include >> =C3=9F is not a complex character, so is never looked at here. But i= f we >> hoist the checking out of the loop over complex characters, we can >> make that work as well (this supersedes my previous patch). >>=20 >> I have no idea of the performance impact of all this. >> [...] >> + (aset equiv (aref roundtrip 0) >> + (cons str (aref equiv (aref roundtrip 0)))= ))) Juri> It seems this adds a symmetric decomposition from the first chara= cter of "ss", Juri> i.e. from ?s to "=C3=9F". Shouldn't this rather update 'equiv-mu= lti' instead? Yes, thinko on my part. Juri> OTOH, I see no reason to add symmetric decompositions by default = since Juri> they are handled by the option 'char-fold-symmetric'. OK. Sounds like v1 is the winner. I=CA=BCll clean it up and commit when rea= dy. Robert