From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.devel Subject: Review request (compilation-error-regexp-alist-alist) Date: Mon, 28 Oct 2019 23:50:59 +0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="216525"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 28 21:51:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iPBz6-000uAI-GN for ged-emacs-devel@m.gmane.org; Mon, 28 Oct 2019 21:51:29 +0100 Original-Received: from localhost ([::1]:39842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPBz5-0001El-4O for ged-emacs-devel@m.gmane.org; Mon, 28 Oct 2019 16:51:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34427) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPByp-000144-Ip for emacs-devel@gnu.org; Mon, 28 Oct 2019 16:51:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPByj-0004cj-RW for emacs-devel@gnu.org; Mon, 28 Oct 2019 16:51:07 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35649) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPByj-0004a1-GU for emacs-devel@gnu.org; Mon, 28 Oct 2019 16:51:05 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B2E0421E3E for ; Mon, 28 Oct 2019 16:51:01 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 16:51:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=VgoW2M2ArFKWsRA8MRD7jCiBcipZH2IjZ1Kz8eff5Fk=; b=gNa0wI5R iZ50hveLOymfdYI4T2T0DDzr4UdjIp716ovfRSZF4Wk+I+7mjSzot8TjdWKUTMQr cWYkZMfemSMQMuDQuF0PpjoHG9SMtIh5Qy0Mgp1WUiuB0kvsiL0QfZzv5qxSP/wu ClQZJy8JpI7LX4mZjb1ML1m3ef5XzEBApUfPAdpP9TrQCpPYRPamJi/ZxkLDioUQ MdWkAfYDHwlQRJWqawDMPlaTxcpKKVejgWyMvWuCLvkPekCgSht/shbR1fNgW5v4 UKpB757Llyvx0pt8Rt4Ouw3zeeIm5BlCFaO0wCgNo+2rV70L6gtoyrO7e1bQYw+s S2T4WgH9kpzdpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=VgoW2M2ArFKWsRA8MRD7jCiBcipZH 2IjZ1Kz8eff5Fk=; b=u699aAcUqffdeHhaNjjnNe46NhvnKcNDSqrvdR/EE+iwY K3J4rwJnReaSuMfiXXHkQMSvJAnJfcmyEHTclIBLzmxk6tqT3mu5iBxT44SoXPL8 96Od7ZOkURNm5RWJiNy1h+EIFTCe2B5PRA05LJMkn+HrB0cEejxMWdPtxhMWypp5 j2c1QAVRGtIIGjaFJ0ZM3H36LYHvh+PnzOoqzf9R7nJ6hGSS+irgig+H4N6fYuyr VP+RERqcEDLG82cddxk6ZhOfuaUEP3/EbzXbgifQ+YcZexQXqtlbbxm5xwvWNJoJ WFjq2gCKv3SVg2XdmOo9V82eFvfpMmXGt7V8XmEyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgddugeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufgffkfggtgesthdtredttd ertdenucfhrhhomhephfhilhhiphhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghs thhmrghilhdrfhhmqeenucfkphepudekhedrfedvrdeikedrudefheenucfrrghrrghmpe hmrghilhhfrhhomhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Original-Received: from fgunbin.local (unknown [185.32.68.135]) by mail.messagingengine.com (Postfix) with ESMTPA id 0712FD6005B for ; Mon, 28 Oct 2019 16:51:00 -0400 (EDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.27 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241558 Archived-At: Hi, could you please review this to check I haven't done anything obviously wrong? Thanks. Filipp diff --git a/etc/compilation.txt b/etc/compilation.txt index 0e39ab5e4a..4a4a318d03 100644 --- a/etc/compilation.txt +++ b/etc/compilation.txt @@ -185,6 +185,14 @@ Warning near line 10 file arrayclash.f: Module contains no executable Nonportable usage near line 31 col 9 file assign.f: mixed default and explicit +* Gradle with kotlin-gradle-plugin + +symbol: gradle-kotlin + +e: /src/Test.kt: (34, 15): foo: bar +w: /src/Test.kt: (34, 15): foo: bar + + * IAR Systems C Compiler symbol: iar diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index cd7a5dc677..24c8a2a312 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -236,6 +236,15 @@ compilation-error-regexp-alist-alist "\\(^Warning .*\\)? line[ \n]\\([0-9]+\\)[ \n]\\(?:col \\([0-9]+\\)[ \n]\\)?file \\([^ :;\n]+\\)" 4 2 3 (1)) + ;; Gradle with kotlin-gradle-plugin (see + ;; GradleStyleMessagerRenderer.kt in kotlin sources). + (gradle-kotlin + ,(concat + "^\\(?:\\(w\\)\\|.\\): *" ;type + "\\(\\(?:[A-Za-z]:\\)?[^:\n]+\\): *" ;file + "(\\([0-9]+\\), *\\([0-9]+\\))") ;line, column + 2 3 4 (1)) + (iar "^\"\\(.*\\)\",\\([0-9]+\\)\\s-+\\(?:Error\\|Warnin\\(g\\)\\)\\[[0-9]+\\]:" 1 2 nil (3)) diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el index 08a369e7b5..e38c31dd0a 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -212,6 +212,13 @@ compile-tests--test-regexps-data 1 nil 27041 "{standard input}") ("boost/container/detail/flat_tree.hpp:589:25: [ skipping 5 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]" 1 25 589 "boost/container/detail/flat_tree.hpp" 0) + ;; gradle-kotlin + ("e: /src/Test.kt: (34, 15): foo: bar" 4 15 34 "/src/Test.kt" 2) + ("w: /src/Test.kt: (11, 98): foo: bar" 4 98 11 "/src/Test.kt" 1) + ("e: e:/cygwin/src/Test.kt: (34, 15): foo: bar" 4 15 34 "e:/cygwin/src/Test.kt" 2) + ("w: e:/cygwin/src/Test.kt: (11, 98): foo: bar" 4 98 11 "e:/cygwin/src/Test.kt" 1) + ("e: e:\\src\\Test.kt: (34, 15): foo: bar" 4 15 34 "e:\\src\\Test.kt" 2) + ("w: e:\\src\\Test.kt: (11, 98): foo: bar" 4 98 11 "e:\\src\\Test.kt" 1) ;; Guile ("In foo.scm:\n" 1 nil nil "foo.scm") (" 63:4 [call-with-prompt prompt0 ...]" 1 4 63 nil) @@ -413,8 +420,8 @@ compile--test-error-line (compilation-num-warnings-found 0) (compilation-num-infos-found 0)) (mapc #'compile--test-error-line compile-tests--test-regexps-data) - (should (eq compilation-num-errors-found 87)) - (should (eq compilation-num-warnings-found 32)) + (should (eq compilation-num-errors-found 90)) + (should (eq compilation-num-warnings-found 35)) (should (eq compilation-num-infos-found 26))))) (ert-deftest compile-test-grep-regexps ()