unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Roland Winkler <winkler@gnu.org>, emacs-devel@gnu.org
Subject: Re: process-file instead of call-process in proced.el?
Date: Mon, 28 Mar 2022 17:53:19 +0300	[thread overview]
Message-ID: <m2v8vy163k.fsf@fastmail.fm> (raw)
In-Reply-To: <87tubjfpyo.fsf@gmx.de> (Michael Albinus's message of "Sun, 27 Mar 2022 16:08:15 +0200")

Michael, thanks for working on this,

On 27/03/2022 16:08 +0200, Michael Albinus wrote:

> +      (if (tramp-compat-funcall
> +           'tramp-send-command-and-check
> +           vec (format "\\kill -%s %d" sigcode pid))
> +          0 -1))))
> +

Can the command be a connection-local variable?.  Then the ability to
customize, existing before deprecation of proced-signal-function, would
not be lost.

>        (setq priority (number-to-string priority)))
> -  (let (failures)
> +  (let ((default-directory
> +         (if (and current-prefix-arg (stringp proced-remote-directory))
> +             proced-remote-directory temporary-file-directory))
> +        failures)

As for me, I'd leave the proced-remote-directory thing out.  IIUC, it
allows to send signals to remote processes from "normal" proced buffer,
with local default-directory (with prefix arg).  I'd be fine with
requiring user to open proced from remote directory, with
default-directory already "prepared".

Thanks.
Filipp



  parent reply	other threads:[~2022-03-28 14:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25  0:09 process-file instead of call-process in proced.el? Filipp Gunbin
2022-03-25  6:54 ` Eli Zaretskii
2022-03-25 10:24   ` Filipp Gunbin
2022-03-25 10:31     ` Eli Zaretskii
2022-03-25 11:46       ` Michael Albinus
2022-03-25 12:12         ` Eli Zaretskii
2022-03-25 12:29           ` Filipp Gunbin
2022-03-25 13:34             ` Roland Winkler
2022-03-25 13:58             ` Michael Albinus
2022-03-25 14:26               ` Filipp Gunbin
2022-03-25 14:29                 ` Michael Albinus
2022-03-25 15:40                   ` Filipp Gunbin
2022-03-25 15:43                     ` Michael Albinus
2022-03-26 16:49 ` Michael Albinus
2022-03-26 17:37   ` Roland Winkler
2022-03-26 18:31     ` Michael Albinus
2022-03-26 18:49       ` Roland Winkler
2022-03-27  7:28         ` Michael Albinus
2022-03-27 14:08           ` Michael Albinus
2022-03-28  2:57             ` Roland Winkler
2022-03-28  7:41               ` Michael Albinus
2022-03-28 14:34                 ` Roland Winkler
2022-03-28 14:53             ` Filipp Gunbin [this message]
2022-03-28 15:40               ` Michael Albinus
2022-03-28 16:11                 ` Filipp Gunbin
2022-03-28 16:39                   ` Michael Albinus
2022-03-28 19:42                     ` Filipp Gunbin
2022-03-30 11:20                       ` Michael Albinus
2022-03-30 15:34                         ` Filipp Gunbin
2022-03-28 17:08             ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2v8vy163k.fsf@fastmail.fm \
    --to=fgunbin@fastmail.fm \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).