unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Arash Esbati <arash@gnu.org>
To: emacs-devel@gnu.org
Cc: Eshel Yaron <me@eshelyaron.com>
Subject: Re: master 47e313e9805: Unbind 'C-M-i' in Text mode
Date: Wed, 29 Nov 2023 20:11:15 +0100	[thread overview]
Message-ID: <m2v89kz86k.fsf@macmutant.fritz.box> (raw)
In-Reply-To: <20231126103911.6CEAFC25D5B@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 26 Nov 2023 05:39:11 -0500 (EST)")

Eli Zaretskii <eliz@gnu.org> writes:

> branch: master
> commit 47e313e9805c527e590df4270062a9185ee9db78
> Author: Eshel Yaron <me@eshelyaron.com>
> Commit: Eli Zaretskii <eliz@gnu.org>
> [...]
> diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el
> index ccba1b063ab..7f38a1c463d 100644
> --- a/lisp/textmodes/text-mode.el
> +++ b/lisp/textmodes/text-mode.el
> [...]
> @@ -131,7 +143,8 @@ Turning on Text mode runs the normal hook `text-mode-hook'."
>  
>    ;; Enable text conversion in this buffer.
>    (setq-local text-conversion-style t)
> -  (add-hook 'context-menu-functions 'text-mode-context-menu 10 t))
> +  (add-hook 'context-menu-functions 'text-mode-context-menu 10 t)
> +  (add-hook 'completion-at-point-functions #'ispell-completion-at-point 10 t))
>  
>  (define-derived-mode paragraph-indent-text-mode text-mode "Parindent"
>    "Major mode for editing text, with leading spaces starting a paragraph.

I think this part of the change now throws:

    ELC+ELN  ../lisp/textmodes/text-mode.elc
  In end of data:
  text-mode.el:147:46: Warning: the function ‘ispell-completion-at-point’
  is not known to be defined.

Maybe declare'ing the function helps?  This is with Emacs 30
(a811846879) on macOS.

Best, Arash



       reply	other threads:[~2023-11-29 19:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170099515102.15929.4538081255360222923@vcs2.savannah.gnu.org>
     [not found] ` <20231126103911.6CEAFC25D5B@vcs2.savannah.gnu.org>
2023-11-29 19:11   ` Arash Esbati [this message]
2023-11-30  6:07     ` master 47e313e9805: Unbind 'C-M-i' in Text mode Eli Zaretskii
2023-11-30  7:40       ` Arash Esbati
2023-11-30  8:41         ` Eli Zaretskii
2023-11-30 10:46           ` Arash Esbati
2023-11-30 17:17             ` Juri Linkov
2023-12-05 23:26   ` Dmitry Gutov
2023-12-06  7:53     ` Eshel Yaron
2023-12-06 12:45       ` Dmitry Gutov
2023-12-06 13:56         ` Eshel Yaron
2023-12-06 14:33           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2v89kz86k.fsf@macmutant.fritz.box \
    --to=arash@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=me@eshelyaron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).