From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: MPS: Forwording symbols Date: Mon, 17 Jun 2024 20:39:43 +0200 Message-ID: References: <87jziod6yc.fsf@gmail.com> <874j9rcuf6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34212"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Emacs Devel , Eli Zaretskii To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 17 20:40:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJHHY-0008hw-Ok for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Jun 2024 20:40:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJHGj-000740-Oz; Mon, 17 Jun 2024 14:39:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJHGg-00073F-4s for emacs-devel@gnu.org; Mon, 17 Jun 2024 14:39:50 -0400 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJHGe-0001oh-K9; Mon, 17 Jun 2024 14:39:49 -0400 Original-Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-57c6994e2f1so2626690a12.0; Mon, 17 Jun 2024 11:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718649585; x=1719254385; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3ajEvQLOSWnCB7Sx6Wb+Kw6KfGcEFEzBXXXns5HaLXk=; b=ZjHSjIquLjD1X+pIdVtt2/5+as8ZxiHN6llmkDza0bmVqW08a3O1TXwVG1Jq3VPNMF ANVLvB9Y6vlPqlFP7B/GMJ4f+l0TUsQyDPXG6T4a7TgrR9XL8gsDguvqTg5sdwubOhmd 0ArnDMB08A6PYPkcq0gwvFdMuRRJPR9SXm2t0kFiqxx9MkadTkI7CwZQsqr4EjHpdQsq wnCMLG94HQs6Hfir9OHIG1fFPV94m08MprnpZBpHdICLtb/i57c2riWDN3skGyARIRj+ ZubeArK6D+Foy8btj+iTG7nPJLgm4xfHxVq9VsiU7qgXIUMS4tdPkX9/2g5qL6lOxTV5 N6Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718649585; x=1719254385; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3ajEvQLOSWnCB7Sx6Wb+Kw6KfGcEFEzBXXXns5HaLXk=; b=aWEX8hY2O50wFiJ1H1tveNPU21GwWP5Oe5Bk612VjRAMMnYyfo0emVOM8BxRGUDdT5 U9DBTRbvkdDUMoCho5FywQz66tAqdj2risVpGq/K7f4jOsFsu3VHxA6JOUwiQZEyUt4Z bvUWMYdHqKSUlJrxDCcf4Bj1GT0tApA+yL0iO8xpAnzJd11jgE458MAbbMNOrBUYxt7T /VQBpX1HmtAjdIo+5jwvZ25fACRThgljr2f03adntrIjtgkl90atdHYFrJPGubNyyYv8 koWrsvCtvczGUT7p7OH0CQ2rD+Ji5BNzWBUIZLonNm34bp9K01Ma9bgh7eUFjzqJmLrf vuAA== X-Forwarded-Encrypted: i=1; AJvYcCULmzVFirBPlrffpgnDxQqDojnkNULMoJsghgnCMpesOHRsP5Dcl2bxOOSKeMycDHmNH8CQez+J/PPqFnc= X-Gm-Message-State: AOJu0Yy4lUhi746cCQa4Jx1HSosIP8GgSFMTP/6XkTnXW9oflt90La2s i2IqslbFDI10NoM68UGaDCdIMxt+aHeubQIyFPVKtjkCy+WkjNAQqffnqw== X-Google-Smtp-Source: AGHT+IGxZmdWWxcxOkDBYyNf+1+YwIDAgaAWQXCYEvFHdpQddX5xnBzU6hiERohhc5cL6UUcuXVuBw== X-Received: by 2002:a50:cc8d:0:b0:57c:dd3a:f399 with SMTP id 4fb4d7f45d1cf-57cdd3af45cmr3907358a12.12.1718649585363; Mon, 17 Jun 2024 11:39:45 -0700 (PDT) Original-Received: from pro2.fritz.box (pd9e36d9b.dip0.t-ipconnect.de. [217.227.109.155]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb72cdf68sm6737227a12.20.2024.06.17.11.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 11:39:44 -0700 (PDT) In-Reply-To: <874j9rcuf6.fsf@gmail.com> (Helmut Eller's message of "Mon, 17 Jun 2024 20:10:05 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=gerd.moellmann@gmail.com; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320216 Archived-At: Helmut Eller writes: > On Mon, Jun 17 2024, Gerd M=C3=B6llmann wrote: > >> The whole dumping of these structs looks highly dubious to me, >> independent of MPS. They are constants, always have been, AFAICT, even >> from what I remember from the 90s. > > The patch below creates the necessary relocs so that no forwarding > structs end up in the dump. Thanks. pushed. > >> Looking forward to the time when the mirror code is gone :-). > > I'm not so optimistic. The first collection is very slow: > > time ./emacs -batch -f igc--collect >=20=20=20=20 > real 0m12.555s > user 0m11.708s > sys 0m0.097s That's pretty slow, indeed. The version of Emacs I'm currently running, which is my fork which does not contain your recent changes, and is an optimized build with -lmps says .../emacs/github/igc % /usr/bin/time src/emacs -batch -f igc--collect 0.25 real 0.14 user 0.11 sys > That's not good. Maybe there is some unfixed problem that is causing > this slowness, but it could also be that MPS simply is so slow for this > allocation pattern. I guess it is what you suspect because I run into an assertion when dumping: Dumping fingerprint: 79b503a407de48b18f4c304971c234d89bf236c259a1e7cd8575= 59f919943b91 igc.c:345: Emacs fatal error: assertion failed: h->obj_type =3D=3D IGC_OB= J_PAD || nbytes >=3D sizeof (struct igc_fwd) Fatal error 6: Aborted That's a build starting from git clean -xdf, optimized, -lmps, and no native compilation here of course. I'll try to debug this, but I think I have to read the new code first a bit to understand where to start.