From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ari.roponen@gmail.com, emacs-devel@gnu.org
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 14 Dec 2018 15:09:14 +0100 [thread overview]
Message-ID: <m2tvjgci9h.fsf@gmail.com> (raw)
In-Reply-To: <831s6kgrtj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Dec 2018 15:29:12 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Fri, 14 Dec 2018 13:18:41 +0100
>> Cc: Ari Roponen <ari.roponen@gmail.com>
>>
>> Eli, what would be your preferred type of solution to avoid this in
>> future?
>
> If at all possible, I prefer a single definition of each struct, with
> as few #ifdef's as possible. If some member is not used in some
> configuration, I prefer to have it anyway, unless it cannot be
> compiled in the configuration(s) that don't use it (e.g., because it
> uses a data type that is only visible in some configurations).
>
This I will do in master.
>> At the very least I propose syncing the comments:
>
> Yes, please push.
This I pushed to emacs-26 as f14d5742db
Robert
next prev parent reply other threads:[~2018-12-14 14:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181214085417.15440.18845@vcs0.savannah.gnu.org>
[not found] ` <20181214085418.6616820538@vcs0.savannah.gnu.org>
2018-12-14 12:18 ` harfbuzz 2f72162: Fix crash in the Cairo build Robert Pluim
2018-12-14 13:29 ` Eli Zaretskii
2018-12-14 14:09 ` Robert Pluim [this message]
2018-12-14 16:16 ` Robert Pluim
2018-12-14 16:45 ` Eli Zaretskii
2018-12-17 12:41 ` Robert Pluim
2018-12-17 17:39 ` Eli Zaretskii
2018-12-18 8:49 ` Robert Pluim
2018-12-18 13:01 ` Robert Pluim
2019-02-08 8:01 ` Robert Pluim
2019-02-08 8:04 ` Robert Pluim
2019-02-08 8:06 ` Robert Pluim
2019-02-08 9:37 ` Eli Zaretskii
2019-02-08 11:46 ` Robert Pluim
2019-02-08 13:14 ` Eli Zaretskii
2019-02-08 14:38 ` Robert Pluim
2019-02-08 16:11 ` Eli Zaretskii
2019-02-08 16:41 ` Robert Pluim
2019-02-08 21:29 ` Eli Zaretskii
2019-02-09 19:20 ` Glenn Morris
2019-02-09 19:34 ` Eli Zaretskii
2019-02-10 14:47 ` Stefan Monnier
2019-02-10 15:28 ` Eli Zaretskii
2019-02-10 18:18 ` Stefan Monnier
2019-02-10 18:48 ` Eli Zaretskii
2019-02-10 18:52 ` Stefan Monnier
2019-02-11 9:56 ` Robert Pluim
2019-02-10 18:30 ` Glenn Morris
2019-02-10 14:57 ` Eli Zaretskii
2019-02-10 18:36 ` Glenn Morris
2019-02-11 15:33 ` Eli Zaretskii
2018-12-17 21:49 ` Paul Eggert
2018-12-18 8:23 ` Robert Pluim
2018-12-19 8:32 ` Robert Pluim
2018-12-19 15:06 ` Eli Zaretskii
2018-12-14 20:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2tvjgci9h.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=ari.roponen@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).